rclcpp_components: Fix compilation with clang (backport #3229) - #3231
Merged
Conversation
This fixes the following error reported by clang:
/ros/rclcpp/rclcpp_components/src/component_container.cpp:204:50: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
204 | RCUTILS_LOG_DEBUG_NAMED("component_container", debug_msg.c_str());
| ^~~~~~~~~~~~~~~~~
/nix/store/2xvm1s7bkzj40vswqm9ihlfmq7bxb291-ros-env/include/rcutils/rcutils/logging_macros.h:352:55: note: expanded from macro 'RCUTILS_LOG_DEBUG_NAMED'
352 | RCUTILS_LOG_NAMED(RCUTILS_LOG_SEVERITY_DEBUG, name, __VA_ARGS__)
| ^~~~~~~~~~~
/nix/store/2xvm1s7bkzj40vswqm9ihlfmq7bxb291-ros-env/include/rcutils/rcutils/logging_macros.h:56:73: note: expanded from macro 'RCUTILS_LOG_NAMED'
56 | rcutils_log_internal(&__rcutils_logging_location, severity, name, __VA_ARGS__); \
| ^~~~~~~~~~~
/home/wsh/src/ros/rclcpp/rclcpp_components/src/component_container.cpp:204:50: note: treat the string as an argument to avoid this
204 | RCUTILS_LOG_DEBUG_NAMED("component_container", debug_msg.c_str());
| ^
| "%s",
/nix/store/2xvm1s7bkzj40vswqm9ihlfmq7bxb291-ros-env/include/rcutils/rcutils/logging_macros.h:352:55: note: expanded from macro 'RCUTILS_LOG_DEBUG_NAMED'
352 | RCUTILS_LOG_NAMED(RCUTILS_LOG_SEVERITY_DEBUG, name, __VA_ARGS__)
| ^
/nix/store/2xvm1s7bkzj40vswqm9ihlfmq7bxb291-ros-env/include/rcutils/rcutils/logging_macros.h:56:73: note: expanded from macro 'RCUTILS_LOG_NAMED'
56 | rcutils_log_internal(&__rcutils_logging_location, severity, name, __VA_ARGS__); \
| ^
Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
(cherry picked from commit 329abd8)
ahcorde
approved these changes
Aug 20, 2026
Contributor
|
Pulls: #3231
|
Contributor
Author
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes the following error reported by clang:
Is this user-facing behavior change?
No
Did you use Generative AI?
No
This is an automatic backport of pull request #3229 done by [Mergify](https://mergify.com).