Repository navigation
fix(intune-anomalies): show deprecated setting values by their Intune name - #11
Merged
Merged
Conversation
… name ConfiguredValue on a deprecated-setting row was the option id, such as com.apple.applicationaccess_allowgenmoji_false. It is now the option's label from the expanded setting definition (False), or the part after the definition id when the definition has no label for it. The Maester pack shows this column; the HTML report does not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Label conversion also alters literal simple-setting values and must be restricted to choice-setting types.
1 open issue
What changed in this PR
This PR makes deprecated-setting configured values more readable for downstream consumers such as the Maester pack, without changing the HTML report.
Changes:
- Map configured option IDs to Intune labels, falling back to the suffix after the definition ID.
- Add a regression test for label lookup and fallback behavior.
- Update the changelog and report comments.
| File | Description |
|---|---|
| Tests/IntuneAnomalyCore.Tests.ps1 | Tests option labels and definition-prefix fallback. |
| module/Private/IntuneAnomalies.ps1 | Clarifies in comments why the report omits configured values. |
| module/Core/IntuneAnomalyResolvers.ps1 | Collects option labels and converts deprecated-setting values. |
| CHANGELOG.md | Documents the readable configured-value change. |
Review effort: Balanced
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
ConfiguredValueon a deprecated-setting row was the option id, such ascom.apple.applicationaccess_allowgenmoji_false. It is now the option's label from the expanded setting definition (False), or the part after the definition id when the definition has no label for it. Simple values stay as they are; collection values are mapped one by one.Only the Maester pack (MP.RKS.IA.1008) shows this column; the HTML report does not, so the report looks the same. After the merge, the sync workflow opens the first real sync PR in royklo/maester-pack-rksolutions (pack 0.1.3).
Related issue
None.
Checklist
Invoke-Pester ./Tests, 74 passed, 0 failed (the new test failed before the fix)Test-MtPackvalid, Low, 0 findings; all eight pack tests run; pack Pester 25 passed🤖 Generated with Claude Code