Repository navigation
Conversation
When an internal wait while we processed a stop, or the check that resume_execution() makes before resuming the tracee, collected the tracee's PTRACE_EVENT_EXIT stop, we left that stop for the scheduler. While a thread group is in execve the scheduler only waits for new statuses, so recording hung when the exec's SIGKILL reached a thread while we advanced it through the syscallbuf to the desched disarm after its desched'd read returned, or when the exec'ing thread was SIGKILLed while we processed its execve entry. Handle the exit in the same step, as we already did after handle_signal_event(), and add a kill point after the execve's syscall-entry stop to test the latter. Tests: exec_after_waking_readers, exec_killed_after_entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Patch and test by AI based on human suggestion in review of a previous revision - part of the same series as #4147]
When an internal wait while we processed a stop, or the check that resume_execution() makes before resuming the tracee, collected the tracee's PTRACE_EVENT_EXIT stop, we left that stop for the scheduler. While a thread group is in execve the scheduler only waits for new statuses, so recording hung when the exec's SIGKILL reached a thread while we advanced it through the syscallbuf to the desched disarm after its desched'd read returned, or when the exec'ing thread was SIGKILLed while we processed its execve entry. Handle the exit in the same step, as we already did after handle_signal_event(), and add a kill point after the execve's syscall-entry stop to test the latter.
Tests: exec_after_waking_readers, exec_killed_after_entry.