Repository navigation
Add an offline mock of the RSpace ELN and Inventory APIs for the test suite - #61
Merged
Merged
Conversation
tilorspace
added this pull request to stack #65
September 21, 2026 12:29
tilorspace
marked this pull request as ready for review
September 21, 2026 12:44
This was referenced Oct 9, 2026
tilorspace
added a commit
that referenced
this pull request
Oct 12, 2026
…e filesystems need (#60) Client layer: rebase advertised links, refuse redirects, add calls the filesystems need (#60) Changes to the ELN and Inventory REST clients that the filesystem work needs, plus fixes that stand on their own: - Links the server advertises in `_links` are rebased onto the configured base URL, path prefix included, so next-page and download links work behind a port-forward, in a container, or behind a proxy that serves RSpace under a sub-path such as /rspace. - The shared session never follows an HTTP redirect, because requests would carry the apiKey header to the new host. - doDelete tolerates a leading slash, which fixes delete_document. - ELNClient.upload_file and InventoryClient.upload_attachment_by_global_id take an optional filename=; list_folder_tree takes page_size=. - New InventoryClient.get_workbench_by_id (/containers answers 422 for a bench) and attach_gallery_file_by_global_id (link an existing Gallery file to an Inventory record). - Inventory CSV import goes through the shared session, so it gets the same timeout, retries and error handling as every other request. - A stray debug print is removed from upload_attachment_by_global_id. Review follow-up: the path-prefix handling in link rebasing, and unit tests for each changed or new client method (client_methods_test.py). Stack: this was part 1 of five PRs towards a unified PyFilesystem (#58). On 2026-10-06 the filesystem was moved to fsspec instead, so parts 3 to 5 (#62, #63, #64) were closed without merging. This client layer and the offline mock server (#61) are independent of the filesystem framework and are kept. The fsspec filesystem itself is #68, which builds on #61. Merge #61 next, then retarget #68 to main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… suite A standard-library HTTP server covering the endpoints the PyFilesystem classes use, backed by an in-memory dataset with the awkward cases a filesystem has to handle (duplicate names, system folders, paginated sections, documents with mixed field types). It counts requests so tests can assert what an operation costs. One server runs for the whole pytest session and `MockServerTestCase` resets its fixtures before each test. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
tilorspace
force-pushed
the
fs-stack/2-mock-server
branch
from
October 12, 2026 07:43
638a685 to
631051a
Compare
tilorspace
added a commit
that referenced
this pull request
Oct 12, 2026
#61 was squash-merged into main; main now holds the same content this branch already had, so the branch keeps its own tree (conftest.py stays deleted, the feature's mock fixtures stay). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A standard-library mock of the ELN (
/api/v1) and Inventory (/api/inventory/v1) endpoints the filesystem classes use, underrspace_client/tests/mock_rspace. Nothing here is installed with the package.server.pyserves an in-memory dataset fromfixtures.pyand counts requests, so a test can assert what a listing costs.conftest.pystarts one server for the whole pytest session;MockServerTestCaseresets its fixtures before every test.The mock doesn't depend on a filesystem framework. No test uses it yet in this PR. #68 adds the fsspec filesystem tests, the Galaxy contract test and the plugin check tool that run against it, and adjusts a few fixtures.
Stack
This started as part 2 of a five-part stack towards a unified PyFilesystem (#58). On 2026-10-06 the filesystem moved to fsspec instead, so parts 3 to 5 (#62, #63, #64) were closed without merging.
main.rspace_client.fsas an fsspec filesystem, built on this PR; replaces Add rspace_client.fs: the Gallery, Inventory and ELN Workspace as one PyFilesystem #62 to Pin what Galaxy's RSpace file source relies on, and add a plugin check tool #64. Once this is merged, Add rspace_client.fs: the Gallery, Inventory and ELN Workspace as one fsspec filesystem #68 is retargeted tomain.🤖 Generated with Claude Code