Skip to content

Fix(ci) integration tests - #66

Merged
nebay-abraha merged 4 commits into
mainfrom
fix/ci-seed-rspace-deployment-properties
Sep 29, 2026
Merged

nebay-abraha merged 4 commits into
mainfrom
fix/ci-seed-rspace-deployment-properties

Conversation

@nebay-abraha

@nebay-abraha nebay-abraha commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor
  • The workflow triggered on master, but the default branch is main, so it never ran on pushes or PRs. Both triggers now point to main.
  • The rspace-web build needs src/main/resources/deployments/dev/deployment.properties. The workflow now copies it from the checked-in .example file before building.
  • We used to built rspace-web backend only without the frontend, now both frontend and backend are build.

MediaFileContentValidator

  • 5 of the 96 integration tests that ran failed all test_import_tree*. Their fixture rspace_client/tests/data/tree/subdir/b.png was an empty 0-byte file. Newer rspace-web runs uploads through MediaFileContentValidator, which rejects a file when its content doesn't match an image extension. Empty bytes don't look like a PNG, so the upload got a 422.

@nebay-abraha nebay-abraha changed the title Fix integration CI: seed rspace-web dev deployment.properties Fix(ci) integration tests Sep 28, 2026
@mKowalski256

Copy link
Copy Markdown
Contributor

Looks good to me!

@nebay-abraha
nebay-abraha merged commit ce8d26e into main Sep 29, 2026
7 checks passed
@nebay-abraha
nebay-abraha deleted the fix/ci-seed-rspace-deployment-properties branch September 29, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants