Skip to content

refactor(create-rstack): unify lib template tsconfig - #376

Merged
chenjiahan merged 4 commits into
mainfrom
align-tests-tsconfig
Aug 19, 2026
Merged

refactor(create-rstack): unify lib template tsconfig#376
chenjiahan merged 4 commits into
mainfrom
align-tests-tsconfig

Conversation

@elecmonkey

@elecmonkey elecmonkey commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary

types and include in tsconfig are overridden, not merged.

  • Restore rstack/types and node in lib templates' tests config, and svelte in app-svelte-ts.
  • Add explicit noEmit to lib-svelte-ts and lib-vue-ts tests config, whose root config uses emitDeclarationOnly.
  • Add the missing tests config to app-lit-ts and lib-node-ts.
  • lib-svelte-ts root: add outDir, drop isolatedModules and module, narrow include to src.

Related to web-infra-dev/rslib#1854

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 19, 2026

Copy link
Copy Markdown

Deploying rstack-cli with  Cloudflare Pages  Cloudflare Pages

Latest commit: f02f245
Status: ✅  Deploy successful!
Preview URL: https://820ef0b7.rstack-cli.pages.dev
Branch Preview URL: https://align-tests-tsconfig.rstack-cli.pages.dev

View logs

Copy link
Copy Markdown
Member

Could we add "rootDir": "src" to template-lib-svelte-ts/tsconfig.json? With outDir set and include narrowed to src, svelte-check reports a TypeScript 6 warning about the implicit common source directory. Setting rootDir explicitly removes the warning and aligns this template with the other library templates.

@elecmonkey

Copy link
Copy Markdown
Member Author

Could we add "rootDir": "src" to template-lib-svelte-ts/tsconfig.json? With outDir set and include narrowed to src, svelte-check reports a TypeScript 6 warning about the implicit common source directory. Setting rootDir explicitly removes the warning and aligns this template with the other library templates.

Makes sense. That's my oversight.

@chenjiahan
chenjiahan merged commit c41cdea into main Aug 19, 2026
5 checks passed
@chenjiahan
chenjiahan deleted the align-tests-tsconfig branch August 19, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants