Conversation
DarioSamo
reviewed
Sep 22, 2026
- fold win32 + win64 guards into just win32 - bump dxc and imgui - clean up/simplify cmakelists changes
Contributor
|
Feel free to point plume to the latest commit now that the other PR is merged. |
Contributor
|
Seems good to me! Just need to put some time aside to test for regressions. Thanks! |
DarioSamo
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to my PR for plume: renderbag/plume#118. Just some minor changes for win32/x86 support.