Repository navigation
release: check that each NIF loads, and publish the sources of the tag - #101
Merged
Merged
Conversation
The bundle check binds every symbol of the NIF and fails on one that no library defines. The publish job checks out the tag and takes the checksum file of the merge, so a change after the tag no longer stops the release.
mix rustler_precompiled.download reads the version from the metadata of the last compile, in a user cache that every checkout shares.
With one pending slot, a newer push cancels the pending run of the checksum merge, and only that run publishes.
rustler_precompiled writes the metadata before the source build, so a compile in another checkout could change it while the build runs.
This was referenced Nov 12, 2026
release: fail the publish job on a failed docs upload, and check the dispatched tag
rubas/kagi_ex#54
Merged
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
The
Publish to Hexjob publishes the tree of the checksum merge, and stops whenlib/,native/, ormix.exsdiffer from the tag:The bundle check of the release build runs
lddfor missing libraries, and on macOS it checks the install names, but neither checks the symbols. The checksum task reads the version from the metadata of the last compile, in~/.cache/rustler_precompiled/metadata, which every checkout shares.Problem
Any merge to
lib/,native/, ormix.exsbetween the version bump and the checksum PR stops the publish job, and the version can then never publish. A change to another packaged file, such asREADME.md, ships unnoticed. A NIF with an undefined symbol gets a tag, a GitHub release, and a Hex version: the aarch64 NIF ofwhisper_ct20.7.1 does exactly that today (rubas/whisper_ct2#99).After
vX.Y.Zand the checksum file of the mergetask checksum:downloadcompiles first, with the metadata in_buildThe same change for the other repos: rubas/cloaked_req#92, rubas/kagi_ex#54, rubas/whisper_cpp#90, rubas/whisper_ct2#100.
Details
The publish job came with #98. It now checks out the tag and takes only the checksum file from the merge, as
whisper_ct2does, so the source comparison goes. A change after the tag ships with the next version. The bundle check runsldd -ron Linux andnm -m -uon macOS. Both bind every symbol, as the BEAM'sRTLD_NOWload does, and the check allows onlyenif_*, which the BEAM defines.The concurrency group now has
queue: max. With the default single slot, a newer push cancels the pending run, and only the run of the checksum merge publishes.A publish job that fails through a bug in the job itself cannot re-run with the fixed workflow file, because only a change of the checksum file starts it. We add no dispatch input for that: a cause in the tag needs a new version anyway, a bug in the job is covered by a patch release or an owner's
mix hex.publishof the tag, and the case has not happened.Checks: zizmor pedantic is clean. A harness ran the new check on the released 0.7.0 NIFs, on the release runners with the codec libraries: all three pass, and a test NIF that misses
MKL_Free_Buffersfails on each runner (https://github.com/rubas/whisper_cpp/actions/runs/43276300228). The publish steps ran onepycagainst v0.7.0: the tree differs from the tag only in the checksum file, and the checksum file equalsSHA256SUMS. The load step fails there, becauseepyclackslibvpx.so.9, which shows that it stops the job.