Repository navigation
Release 0.7.0 - #99
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
@versionis 0.6.0, the version on hex.pm.mainholds the unreleased changes inCHANGELOG.md: theprobe/1codec names (#91), the WAV re-encode fix (#92), FFmpeg 9.0.2 in the precompiled NIFs (#95), and the README fix forlibwebpmux3(#97).Problem
The precompiled NIFs of 0.6.0 bundle FFmpeg 9.0.1, which has three heap writes that a crafted file reaches.
After
@versionsays 0.7.0, the changelog has a 0.7.0 entry, and the README asks for~> 0.7. The merge builds the three NIFs and tagsv0.7.0. The checksum PR follows, and its merge publishes to Hex through #98, where the release waits for an owner's approval.Details
0.7.0, not 0.6.1: the entry starts with a breaking change,
probe/1reports the codec name instead of the decoder name. 0.5.0 and 0.6.0 moved the minor version for breaking changes too. The crate version innative/exmpeg_native/Cargo.tomlhas stayed at 0.1.0 in every release, and stays.