Omit forwarding parameter tests on JRuby - #3092
Merged
Merged
Conversation
The tests added with the forwarding parameter option call the private parser entry points with the option enabled, but the WebAssembly parser shim JRuby loads deliberately rejects it with NotImplementedError (lib/rbs/wasm/parser.rb), so the JRuby suite has been red since the option merged. Omit those tests on JRuby with omit_on_jruby!, as the suite already does for other C-extension-only paths. The schema check for forwarding parameters moves to its own test case so the default method type schema coverage still runs on JRuby. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KscuNdoWHSkZx3iLD2XcbZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JRuby workflow has been failing since #3087 merged (e.g. this run on the merge queue for #3040): the forwarding parameter tests call the private parser entry points with
enable_forwarding_params: true, and the WebAssembly parser shim that JRuby loads deliberately rejects the option withNotImplementedError(lib/rbs/wasm/parser.rb). That produced 4 failures and 3 errors on every JRuby run.This omits the seven affected tests on JRuby with
omit_on_jruby!, following the existing pattern for C-extension-only paths (e.g.test/rbs/wasm/serialization_test.rb):test/rbs/method_type_parsing_test.rb: the six tests that parse with the forwarding option enabled.test_forwarding_parameter_syntax_is_not_enabled_by_defaultandtest_forwarding_parameter_is_not_allowed_in_proc_typeskeep running on JRuby, since they go through the public API, which behaves the same on both parsers.test/rbs/schema_test.rb: the forwarding part oftest_method_type_schemamoves to its own test case (test_method_type_schema_with_forwarding_parameter) so the default method type schema coverage still runs on JRuby.Both files pass on CRuby with the extension compiled, and no library code changes.
Generated by Claude Code