Repository navigation
feat(page): pass the keywords of go_to on to Ferrum - #367
Merged
Merged
Conversation
Page#go_to took only the URL, so Ferrum's referrer:, timeout: and on_timeout: couldn't be used through Cuprite. Ferrum removed permanent: of headers.add in favor of go_to(url, referrer:), so the docs show that instead. The skipped headers specs in driver_spec.rb are removed: they tested Ferrum's per-page headers, the removed temporary/permanent split and propagation to other windows, and set Host, which Chrome rejects.
route
force-pushed
the
feat/go-to-keywords
branch
from
November 20, 2026 10:01
486227b to
234b884
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page#go_totook only the URL, so the keywords of Ferrum'sgo_tocouldn't be used through Cuprite:referrer:,timeout:andon_timeout:raisedArgumentError.go_to(url = nil, **options)passes them on to Ferrum, the pending connections check is unchanged.permanent:ofheaders.addin favor ofgo_to(url, referrer:), sodocs/11-headers.mdshows that instead.with headersspecs inspec/driver_spec.rband theirpopup_headersview are removed. Unskipped, 4 of 5 failed: three setHost, which Chrome rejects inNetwork.setExtraHTTPHeaders(net::ERR_INVALID_ARGUMENT), and the rest expected headers to propagate to other windows or relied on the removed temporary/permanent split. Headers are per page in Ferrum and Cuprite adds nothing on top, so there was nothing of Cuprite's left to cover.Needs Ferrum
mainat rubycdp/ferrum@5743cc8 or later forreferrer:.