Repository navigation
chore(options): deprecate flatten: false and schedule the option for removal in 0.22 - #709
Merged
Merged
Conversation
route
force-pushed
the
deprecate-flatten
branch
from
November 20, 2026 06:51
7e0ced7 to
00b4597
Compare
route
added a commit
that referenced
this pull request
Nov 20, 2026
* ref(events): yield only the params to raw CDP event callbacks The dispatcher passed each callback its index and the total number of callbacks, leaking subscriber internals into on and breaking lambdas and symbol procs taking one argument. Tracing relied on the index and ignored Tracing.tracingComplete unless its callback came first, so a user subscription added before the first record made it time out. * chore(options): deprecate flatten: false and schedule the option for removal in 0.22 (#709)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ferrum::Browser.new(flatten: false)now warns that the option will be removed in 0.22. Passingtrueor nothing stays silent, and the behavior of both modes is unchanged until then.Why
flatten: falseis not CDP's non-flat mode.Target.setAutoAttachandTarget.attachToTargetalways passflatten: true, the option only makes each target open an extra websocket to/devtools/page/<id>on top of its session on the browser connection.Target#build_worker.ws_url, which assumes the endpoint routes/devtools/page/<id>.Changes
Browser::Optionswarns once per call site whenflatten: falseis passeddocs/2-customization.md, RBS and the changelog note the deprecation