Repository navigation
docs(context): note that wait_for_new_page misses pages opened by a modifier or middle click - #712
Merged
Merged
Conversation
…odifier or middle click
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Documents which opened pages
wait_for_new_pageandwait_for_new_page!return, indocs/3-navigation.mdand in the YARD ofContext#wait_for_new_page.Why
Both match a new page target by its opener id. Chrome only sets it for a page another page opened. Checked on Chrome 157 against the raw
Target.getTargetsoutput:openerIdwindow.open, with or withoutnoopenertarget="_blank"link, with or withoutrel="noopener"So a page the user opens from a link is not returned, and
pages(&:opener_id)leaves it out too. The docs now say so and show how to find such a page:Docs only, no behavior change.