Skip to content

fix(browser): delegate off, window_bounds, tracing, activate and document_size to page - #714

Merged
route merged 1 commit into
mainfrom
fix/browser-page-delegates
Nov 20, 2026
Merged

route merged 1 commit into
mainfrom
fix/browser-page-delegates

Conversation

@route

@route route commented Nov 20, 2026

Copy link
Copy Markdown
Member

Browser is kept as a facade over its default page, but some page methods were missing from it: it delegated on but not off, position but not window_bounds, and lacked tracing, activate and document_size. This adds them.

browser.command stays a command to the browser itself (Browser.*, Target.*), unlike browser.on, which subscribes on the default page. The YARD docs and a new "Raw CDP" section in the introduction guide now say so.

Also fixes two RBS signatures: Page#set_window_bounds, a method that no longer exists, is removed, and protected is dropped from Deadline, since RBS can't parse it.

…ment_size to page

Browser delegated on but not off, position but not window_bounds, and missed tracing, activate and document_size.
Document that browser.command goes to the browser itself, unlike on, which subscribes on the default page.
Also fix two RBS signatures: drop set_window_bounds, which no longer exists, and protected in Deadline, which RBS
can't parse.
@route
route merged commit 4c4791b into main Nov 20, 2026
7 checks passed
@route
route deleted the fix/browser-page-delegates branch November 20, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant