Repository navigation
fix(sign): one alerter banner at a time, ended after its timeout - #73
Draft
runewright[bot] wants to merge 1 commit into
Draft
runewright[bot] wants to merge 1 commit into
runewright[bot] wants to merge 1 commit into
Conversation
The sign notifier spawned alerter with a 600 s timeout and never reaped it; when the banner never showed, the process stayed for days, one per sign run. The shell wrapper now ends a previous alerter of the rune-sign group before starting, and a watchdog ends the new one 620 s in. Co-Authored-By: Martin Zeman <N4M3Z@users.noreply.github.com> Claude-Session: https://claude.ai/code/session_01Fds3tf5rS1Ep47q5DGhsr3
github-actions
Bot
added
size:small
|
review/correctness stood down on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for
fable/alerter-once: the session agent fills this body beforerune sign open.Plan
Why this shape, one or two sentences.
Changes
Testing
Release Notes
Note
Show only one macOS alerter banner per sign run, ended by a 620s watchdog
The macOS alerter wrapper in
notifier_commandsnow terminates any existingrune-signalerter group before starting a new banner, so only one banner shows at a time. It also starts a background watchdog that waits 620 seconds and terminates the group, then kills the watchdog when alerter exits. Tests in tests.rs verify the group kill, the watchdog delay, and existing click-activation behavior.Risk: banners now disappear after 620 seconds even if no new run starts; check the watchdog logic in mod.rs.
Macroscope summarized 3464ee0.