Skip to content

chore(build): pin the Rust toolchain to 1.98.1 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
runewright wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(build): pin the Rust toolchain to 1.98.1 #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ on:
pull_request:
branches: [main]

# The Rust release the checks run on. A new stable can add lints that fail
# the crate, so the version moves on purpose, together with the clippy
# sweep that release needs. The quality workflow uses the runner image's
# Rust and does not read this value.
env:
RUST_TOOLCHAIN: "1.98.1"

jobs:
build:
runs-on: ubuntu-latest
Expand All @@ -20,6 +27,7 @@ jobs:

- uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30 # stable
with:
toolchain: ${{ env.RUST_TOOLCHAIN }}
components: rustfmt, clippy

- name: Build
Expand All @@ -40,6 +48,7 @@ jobs:

- uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30 # stable
with:
toolchain: ${{ env.RUST_TOOLCHAIN }}
components: clippy

- name: Install mdschema
Expand All @@ -66,6 +75,7 @@ jobs:

- uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30 # stable
with:
toolchain: ${{ env.RUST_TOOLCHAIN }}
components: rustfmt, clippy

- name: Download rune
Expand Down Expand Up @@ -100,6 +110,13 @@ jobs:
with:
persist-credentials: false

# `make validate` in the generated project runs cargo clippy, so
# this job pins the same release as the others.
- uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30 # stable
with:
toolchain: ${{ env.RUST_TOOLCHAIN }}
components: rustfmt, clippy

- name: Download rune
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/).

### Changed

- Pin the Build workflow to Rust 1.98.1 through one `RUST_TOOLCHAIN` value, so a new stable release cannot fail main until its clippy sweep lands with the bump.
- Run the Vale hook with `--no-global`, so the guarded gate reads the repository's style alone and a rule in the machine's global config cannot fail or mask it.
- Rename `rune run --clean-harness-state` to `--clean`, and the JSON field to `clean`. The old spelling and the `_scope` field are gone.
- Change the `rune sign` notification to carry the runedeck.ai mark, a subtitle, and a sound through `terminal-notifier` or `alerter` on macOS and `notify-send` elsewhere.
Expand Down
Loading