Repository navigation
chore: satisfy clippy 1.99 and ruff 0.17 across the tree - #76
Conversation
clippy 1.99 adds assert_is_empty, which asks for an equality assertion against an empty value in place of assert on is_empty, in forty-two test files. ruff 0.17 reports UP017 on the two scripts, which now import datetime.UTC; the scripts already use union annotations, so they need Python 3.10 or later, and the system Python of macOS was never enough for them. Co-Authored-By: Martin Zeman <N4M3Z@users.noreply.github.com>
|
review/correctness stood down on |
|
review/correctness stood down on |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
review/correctness round 1 started on |
|
Claude finished @N4M3Z's task in 1m 37s —— View job Looks good. Every assertion rewrite keeps its original polarity — each
|
Runeseer review — cleanLooks good. Every assertion rewrite keeps its original polarity — each
No open findings · Reviewed |
Rewrites forty-two test files for clippy 1.99's assert_is_empty (an equality assertion against an empty value in place of assert on is_empty) and the two scripts for ruff 0.17's UP017 (datetime.UTC). No behaviour changes. Every cli push failed its hooks on these two baselines; this change clears them. fmt, clippy with -D warnings, 1900 tests, and rune validate pass on the tree.
Note
Fix clippy 1.99 and ruff 0.17 lint failures across the tree
timezone.utcwith the standard-librarydatetime.UTCin check-codex-skill-discovery.py and run-artifact-checks.pyassert!(x == Vec::<String>::new())instead ofassert!(x.is_empty()))Macroscope summarized 669da4a.