Skip to content

chore: satisfy clippy 1.99 and ruff 0.17 across the tree - #76

Merged
N4M3Z merged 1 commit into
mainfrom
change/gate-baseline
Oct 16, 2026
Merged

N4M3Z merged 1 commit into
mainfrom
change/gate-baseline

Conversation

@N4M3Z

@N4M3Z N4M3Z commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Rewrites forty-two test files for clippy 1.99's assert_is_empty (an equality assertion against an empty value in place of assert on is_empty) and the two scripts for ruff 0.17's UP017 (datetime.UTC). No behaviour changes. Every cli push failed its hooks on these two baselines; this change clears them. fmt, clippy with -D warnings, 1900 tests, and rune validate pass on the tree.

Note

Fix clippy 1.99 and ruff 0.17 lint failures across the tree

  • Replaces timezone.utc with the standard-library datetime.UTC in check-codex-skill-discovery.py and run-artifact-checks.py
  • Rewrites empty/non-empty test assertions across Rust tests to explicit comparisons against typed empty values (e.g. assert!(x == Vec::<String>::new()) instead of assert!(x.is_empty()))
  • Behavioral Change: none — test assertions and timestamp formatting are semantically equivalent; no runtime behavior changes

Macroscope summarized 669da4a.

clippy 1.99 adds assert_is_empty, which asks for an equality assertion against an empty value in
place of assert on is_empty, in forty-two test files. ruff 0.17 reports UP017 on the two scripts,
which now import datetime.UTC; the scripts already use union annotations, so they need Python
3.10 or later, and the system Python of macOS was never enough for them.

Co-Authored-By: Martin Zeman <N4M3Z@users.noreply.github.com>
@github-actions github-actions Bot added the size:med auto: changed-lines bucket label Oct 16, 2026
@github-actions

Copy link
Copy Markdown

review/correctness stood down on 669da4ad: free lanes only: deterministic check quality is not green on this head. Apply review:runeseer to force a paid round.

@github-actions

Copy link
Copy Markdown

review/correctness stood down on 669da4ad: free lanes only: deterministic check quality is not green on this head. Apply review:runeseer to force a paid round.

@N4M3Z
N4M3Z marked this pull request as ready for review October 16, 2026 21:12
@N4M3Z
N4M3Z merged commit 5c7c648 into main Oct 16, 2026
35 of 39 checks passed
@N4M3Z
N4M3Z deleted the change/gate-baseline branch October 16, 2026 21:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T21:13:32.760895Z 669da4a Draft marked ready
🔒 Security Review ✅ Completed 2026-10-16T21:14:10.550084Z 669da4a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@runeseer

runeseer Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

review/correctness round 1 started on 669da4ad at ledger generation 1.

@runeseer

runeseer Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @N4M3Z's task in 1m 37s —— View job


Looks good. Every assertion rewrite keeps its original polarity — each !x.is_empty() became assert_ne! and each x.is_empty() became assert_eq! against a typed empty value, so no test silently inverts or weakens.

  • datetime.UTC raises the two scripts' floor to Python 3.11; CI and the repo templates run 3.12, so nothing breaks today.
  • No other reviewer has posted a finding on this head.

@runeseer

runeseer Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Runeseer review — clean

Looks good. Every assertion rewrite keeps its original polarity — each !x.is_empty() became assert_ne! and each x.is_empty() became assert_eq! against a typed empty value, so no test silently inverts or weakens.

  • datetime.UTC raises the two scripts' floor to Python 3.11; CI and the repo templates run 3.12, so nothing breaks today.
  • No other reviewer has posted a finding on this head.

No open findings · Reviewed 669da4ad · review run · $1.08 · 1m37s · 21 turns

@runeseer runeseer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earned approval: review/correctness returned a clean verdict for 669da4a at ledger generation 1. Dismissed automatically on any new push or generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:med auto: changed-lines bucket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant