Skip to content

docs: every occurrence of a term is a link, and the records in the plain register - #76

Open
runewright[bot] wants to merge 10 commits into
mainfrom
fable/records-register
Open

runewright[bot] wants to merge 10 commits into
mainfrom
fable/records-register

fix(terms): link every term occurrence in the files main brought in

ad35e00
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check completed Oct 29, 2026 in 1m 34s

Needs Human Approval

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
This change links ontology terms throughout the documentation and strengthens term validation. Unresolved review concerns remain about misleading term definitions in agent instructions and local enforcement being bypassed with older Rune installations.

Additional Thinking

Code

Requires links at every use of a linked ontology term, updates fallback checking/fixing and coverage parsing, adds fixtures, and rewrites records and glossary references. CI updates its pinned Rune revision and skips the vault-dependent sync-idea check. Effects primarily reach repository authoring and deployed prose guidance; workflow permissions remain read-only.

Review Context

Author runewright changes files owned by N4M3Z; ownership alone is not a veto. Two unresolved external comments raise substantive concerns about misleading Change-term links in agent instructions and skipped local enforcement with older Rune installations. The new capability probe addresses part of the latter concern, but the head's hook still skips the fallback whenever Rune exists. No replies resolving these concerns, check results, or custom customer guidelines were supplied. The configured medium-severity gate applies independently to Macroscope findings; these comments are external.

Verdict

The unresolved external concerns affect agent interpretation of review instructions and whether developers receive the newly required authoring checks. A human must resolve the requested ordinary-word rewording and confirm how older Rune installations obtain every-occurrence enforcement; the supplied threads do not establish either concern as addressed. Other changes are largely documentation and bounded repository validation, without demonstrated production-data effects.

Notes:
@Runewright isn't a code owner for 90 files:

• docs/specs/glossary/open-seal.md (owned by N4M3Z)
• docs/specs/glossary/work-item.md (owned by N4M3Z)
• docs/specs/glossary/lane-table.md (owned by N4M3Z)
• docs/specs/glossary/merge-base.md (owned by N4M3Z)
• docs/specs/glossary/merge-seal.md (owned by N4M3Z)
• docs/specs/glossary/review-funnel.md (owned by N4M3Z)
• docs/specs/glossary/commit-trailer.md (owned by N4M3Z)
• docs/specs/glossary/review-controller.md (owned by N4M3Z)
• docs/specs/glossary/agentic-review-lane.md (owned by N4M3Z)
• tests/test_check_scripts.py (owned by N4M3Z)
• tests/test_fallback_terms.py (owned by N4M3Z)
• ontology/rune.ttl (owned by N4M3Z)
• docs/specs/glossary/projection.md (owned by N4M3Z)
• .github/workflows/safetyfirst.yaml (owned by N4M3Z)
• tests/fixtures/vale/valid/undefined-term.md (owned by N4M3Z)
• docs/specs/glossary/review-scorecard.md (owned by N4M3Z)
• scripts/generate-vale-style.py (owned by N4M3Z)
• .vale/styles/Core/UndefinedTerm.yml (owned by N4M3Z)
• .vale/styles/Core/UnexplainedAbbreviation.yml (owned by N4M3Z)
• scripts/check-coverage (owned by N4M3Z)
• tests/fixtures/vale/valid/unexplained-abbreviation.md (owned by N4M3Z)
• scripts/fallback/check-terms (owned by N4M3Z)
• runes/core/rules/ConsultTheOntology.md (owned by N4M3Z)
• .github/workflows/quality.yaml (owned by N4M3Z)
• docs/changes/environment-variables-supported-syntax/design.md (owned by N4M3Z)
• docs/specs/glossary/index.md (owned by N4M3Z)
• docs/proofs/plain-text-first-principles/README.md (owned by N4M3Z)
• scripts/fallback/fix-terms (owned by N4M3Z)
• docs/changes/quality-new-branch-base/specs/quality-new-branch-base/spec.md (owned by N4M3Z)
• docs/changes/one-instance-per-model/proposal.md (owned by N4M3Z)
• docs/changes/plain-text-first-principles/specs/single-source-of-truth/spec.md (owned by N4M3Z)
• and 59 files omitted


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.