Repository navigation
Update PMUSERENR_EL0 flag names - #85
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new EN::Trapped name incorrectly implies unconditional trapping despite documented exceptions.
1 open finding
What changed in this PR
Updates PMUSERENR_EL0 field naming, documentation, and write support.
Changes:
- Clarifies register and field semantics.
- Renames field values to reflect trapping behavior.
- Adds typed writable-register support.
| File | Description |
|---|---|
packages/aarch64-cpu/src/registers/pmuserenr_el0.rs |
Updates flags, documentation, and register writability. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Add writability.
berkus
force-pushed
the
update-pmuserenr-el0-flag-names
branch
from
October 8, 2026 22:55
e268f0a to
80ae164
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename fields to more understandable. Add writability.