Repository navigation
Implement Index<usize> and IndexMut<usize> for Deque - #697
Open
mikwielgus wants to merge 1 commit into
Open
mikwielgus wants to merge 1 commit into
mikwielgus wants to merge 1 commit into
Conversation
This continues f70f19c. This is consistent with standard library's `VecDeque`, which also has `Index<usize>` and `IndexMut<usize>` implemented.
mikwielgus
force-pushed
the
index-index-mut-for-vecdeque
branch
from
November 3, 2026 20:54
4cd0cc8 to
c297961
Compare
sgued
requested changes
Nov 7, 2026
sgued
left a comment
sgued
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
The implementation looks good to me, just one nit regarding the tests.
Comment on lines
+1900
to
+1916
| fn increment<C>(container: &mut C, index: usize) | ||
| where | ||
| C: std::ops::IndexMut<usize>, | ||
| C::Output: std::ops::AddAssign<i32>, | ||
| { | ||
| container[index] += 1; | ||
| } | ||
|
|
||
| increment(&mut q, 1); | ||
| assert_eq!(q[1], 10); | ||
|
|
||
| fn get<C>(container: &C, index: usize) -> &<C as core::ops::Index<usize>>::Output | ||
| where | ||
| C: std::ops::Index<usize>, | ||
| { | ||
| &container[index] | ||
| } |
Contributor
There was a problem hiding this comment.
Deque doesn't implement deref, so I don't think the added function is necessary to make sure the right implementation is tested.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues f70f19c.
This is consistent with standard library's
VecDeque, which also hasIndex<usize>andIndexMut<usize>implemented.