Repository navigation
Make String::from_utf8_unchecked const - #698
Merged
sgued merged 1 commit intoNov 7, 2026
Merged
Conversation
rust-embedded#527 made it const, but the generic length type from rust-embedded#504 rewrote the function and dropped `const` before any release included it. Refs rust-embedded#515.
This was referenced Nov 7, 2026
Contributor
|
LGTM |
sgued
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#527 made
String::from_utf8_uncheckedconst. #504 then had to dropconst, because the body started calling the non-constcast_len_type. #552 removed that call again, butconstwas never restored. As a result, no release has it const, even though the v0.9.0 changelog lists it.Related: #515.
I plan to do more const work, but I thought I'd start with the low-hanging fruit.
AI disclosure
I used Claude (Opus 5.5 extra-high) to
I manually verified and adjusted of course :)