Avoid reading beyond completed fixed-size chunks. - #1130
Open
RanaPriyansh wants to merge 1 commit into
Open
RanaPriyansh wants to merge 1 commit into
RanaPriyansh wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1035.
Consuming a complete chunk reads one extra source element to detect the chunk boundary. That element is lost when the chunking adaptor is dropped. Track each chunk's remaining capacity and stop before reading beyond it. Release completed buffered chunks without reading another source element. Key-based grouping keeps its existing boundary detection.
The regression fails on the unpatched baseline and passes on the candidate. Tests cover source position, chunk boundaries, interleaved live chunks, partial drops, exhaustion, and bounded retention after repeated live chunk pairs.
cargo test --all-featurespasses: 449 tests and 210 doctests. Strict documentation and formatting checks pass on Rust 1.97.The four CI Clippy configurations fail on existing
question_markdiagnostics. Baseline comparisons reproduce the same diagnostics in all four configurations. Rust 1.63 MSRV, Miri, and semver checks have not run locally.Prepared with AI assistance.