Repository navigation
Deny unsafe operations in unsafe functions - #771
akashchamp wants to merge 1 commit into
Conversation
Signed-off-by: Akash Kumar <116457960+akashchamp@users.noreply.github.com>
|
The two red i686-msvc jobs die in the rustup install step on the new windows-2025 runner image ("toolchain 'stable-i686-msvc' may not be able to run on this system") before any code is built, and #755 fails the same way, so it looks like a CI image regression rather than something from this change. I checked i686-pc-windows-msvc, x86_64-pc-windows-msvc, i686-pc-windows-gnu and aarch64-pc-windows-msvc locally with RUSTFLAGS=-Dwarnings and they all compile clean with the lint denied. |
83fef93 to
f7bc909
Compare
|
I am surprised this just works! |
|
...using, afaict, an LLM to generate even a trivial PR (come on, |
|
I appreciate that you changed your profile. There obviously wasn't a problem in just the code, from my first skim, which is why I hit the approval, but I started to feel unsure about my reasoning for even wanting the change, so I began working on revising the PR description until I understood why again. That's when I noticed what I did. I am guessing you are simply new to all this. It is not unwarranted to take some pride in one's achievements, either, there's just... a matter of taste that is hard to draw the line for. I have no intention of holding a mistake in doing so against you in the long run. Unfortunately, not begrudging you for a mistake is easier if I don't enshrine that mistake in this repo with a commit that will remind me of it every time I flip by it in the commit log. So, I will be closing this PR. That way, when we next meet, it will be easy for me to be fair and kind. My apologies. |
Fixes #643
Enable
unsafe_op_in_unsafe_fnat the crate root so unsafe operations inside unsafe functions remain explicitly marked. This is explicitly done despite it being implied by edition so it does not vary based on whether it is a separate crate or included in another crate via#[path]hacks.