Repository navigation
fix(build-rs): make unstable compile - #17489
Merged
Merged
Conversation
* `doc_auto_cfg` got merged into `doc_cfg` in 1.92 via rust-lang/rust#138907 * cfg `doc` is set for all channels so it fail on stagle channel because of `#[feature(...)]`. Use `docsrs` instead
…nment` It was renamed and stabilized in rust-lang/rust#155006 in 1.97.
rustbot
added
A-build-scripts
Collaborator
|
r? @Muscraft rustbot has assigned @Muscraft. Use Why was this reviewer chosen?The reviewer was selected based on:
|
epage
approved these changes
Sep 19, 2026
weihanglo
enabled auto-merge
September 20, 2026 02:08
Merged
via the queue into
rust-lang:master
with commit Sep 20, 2026
168501b
106 of 113 checks passed
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 22, 2026
Update cargo submodule 10 commits in 495c385d0875c4ba51eb72ea0448a2d4c018b8d4..98a09e7e7d62850f14e5b6132101fc1edd19a16f 2026-09-16 12:48:58 +0000 to 2026-09-21 19:03:16 +0000 - feat(build-rs): trim-paths inputs (rust-lang/cargo#17491) - Remove README CI badge (rust-lang/cargo#17495) - feat(builtin-deps): Add unstable `builtin-dependencies` feature (rust-lang/cargo#17497) - test(prerelease): concurrent downloads snapshots be unordered (rust-lang/cargo#17492) - Account for (uplift) hardlinks when calculating clean file size (rust-lang/cargo#17485) - feat(hints): extract mostly-unused diagnostics (rust-lang/cargo#17457) - fix(build-rs): make `unstable` compile (rust-lang/cargo#17489) - refactor(context): Split config keys in code, not at runtime (rust-lang/cargo#17490) - fix(prerelease): preserve locked prerelease deps (rust-lang/cargo#17464) - Remove -Zasymmetric-token / cargo:paseto (rust-lang/cargo#17486) r? ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 23, 2026
Update cargo submodule 10 commits in 495c385d0875c4ba51eb72ea0448a2d4c018b8d4..98a09e7e7d62850f14e5b6132101fc1edd19a16f 2026-09-16 12:48:58 +0000 to 2026-09-21 19:03:16 +0000 - feat(build-rs): trim-paths inputs (rust-lang/cargo#17491) - Remove README CI badge (rust-lang/cargo#17495) - feat(builtin-deps): Add unstable `builtin-dependencies` feature (rust-lang/cargo#17497) - test(prerelease): concurrent downloads snapshots be unordered (rust-lang/cargo#17492) - Account for (uplift) hardlinks when calculating clean file size (rust-lang/cargo#17485) - feat(hints): extract mostly-unused diagnostics (rust-lang/cargo#17457) - fix(build-rs): make `unstable` compile (rust-lang/cargo#17489) - refactor(context): Split config keys in code, not at runtime (rust-lang/cargo#17490) - fix(prerelease): preserve locked prerelease deps (rust-lang/cargo#17464) - Remove -Zasymmetric-token / cargo:paseto (rust-lang/cargo#17486) r? ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 23, 2026
Update cargo submodule 10 commits in 495c385d0875c4ba51eb72ea0448a2d4c018b8d4..98a09e7e7d62850f14e5b6132101fc1edd19a16f 2026-09-16 12:48:58 +0000 to 2026-09-21 19:03:16 +0000 - feat(build-rs): trim-paths inputs (rust-lang/cargo#17491) - Remove README CI badge (rust-lang/cargo#17495) - feat(builtin-deps): Add unstable `builtin-dependencies` feature (rust-lang/cargo#17497) - test(prerelease): concurrent downloads snapshots be unordered (rust-lang/cargo#17492) - Account for (uplift) hardlinks when calculating clean file size (rust-lang/cargo#17485) - feat(hints): extract mostly-unused diagnostics (rust-lang/cargo#17457) - fix(build-rs): make `unstable` compile (rust-lang/cargo#17489) - refactor(context): Split config keys in code, not at runtime (rust-lang/cargo#17490) - fix(prerelease): preserve locked prerelease deps (rust-lang/cargo#17464) - Remove -Zasymmetric-token / cargo:paseto (rust-lang/cargo#17486) r? ghost
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Sep 24, 2026
Update cargo submodule 10 commits in 495c385d0875c4ba51eb72ea0448a2d4c018b8d4..98a09e7e7d62850f14e5b6132101fc1edd19a16f 2026-09-16 12:48:58 +0000 to 2026-09-21 19:03:16 +0000 - feat(build-rs): trim-paths inputs (rust-lang/cargo#17491) - Remove README CI badge (rust-lang/cargo#17495) - feat(builtin-deps): Add unstable `builtin-dependencies` feature (rust-lang/cargo#17497) - test(prerelease): concurrent downloads snapshots be unordered (rust-lang/cargo#17492) - Account for (uplift) hardlinks when calculating clean file size (rust-lang/cargo#17485) - feat(hints): extract mostly-unused diagnostics (rust-lang/cargo#17457) - fix(build-rs): make `unstable` compile (rust-lang/cargo#17489) - refactor(context): Split config keys in code, not at runtime (rust-lang/cargo#17490) - fix(prerelease): preserve locked prerelease deps (rust-lang/cargo#17464) - Remove -Zasymmetric-token / cargo:paseto (rust-lang/cargo#17486) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This was found when addressing #17488 (comment): adding trim-paths env vars support in build-rs.
Apparently the
unstableCargo feature in build-rs has been broken for a long while but nobody noticed.How to test and review this PR?
New CI step should help verify it.
🤖 LLM disclosure: LLM helped me find new stable cfg name.