Skip to content

[beta 1.100] fix(config): Apply dotted tuple support for rustflags - #17605

Merged
weihanglo merged 2 commits into
rust-lang:rust-1.100.0from
jannic-dev-forks:fix-rustflags-with-dotted-tuple-backport
Oct 17, 2026
Merged

weihanglo merged 2 commits into
rust-lang:rust-1.100.0from
jannic-dev-forks:fix-rustflags-with-dotted-tuple-backport

Conversation

@jannic

@jannic jannic commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Note that the actual test output and error code depend on whether
the `thumbv8m.main-none-eabihf` target is installed. So as-is this
is not a good test case.

However, the correct behavior is be to fail with
"[ERROR] unknown unstable option: `bogus`". So this test case will
be replaced with the next commit anyway.
The fallback introduced with rust-lang#17536 didn't cover rustflags yet.
@rustbot rustbot added A-cfg-expr Area: Platform cfg expressions S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2026
@rustbot

rustbot commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Muscraft, @epage, @weihanglo
  • @Muscraft, @epage, @weihanglo expanded to Muscraft, epage, weihanglo
  • Random selection from Muscraft, epage, weihanglo

@rustbot

rustbot commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.100.0. Please double check that you specified the right target!

@weihanglo weihanglo left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a backport PR!

View changes since this review

@weihanglo
weihanglo enabled auto-merge October 17, 2026 14:35
@weihanglo
weihanglo merged commit 72b77b8 into rust-lang:rust-1.100.0 Oct 17, 2026
28 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2026
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Oct 17, 2026
[beta-1.100] Update cargo submodule

2 commits in 7552a885e7c68a5b5a3dfc5c158059983ac3efb7..72b77b8d94ec3e2fca533266d88561e527aabe25
2026-09-29 18:08:50 -0400 to 2026-10-17 10:39:00 -0400
- [beta 1.100] fix(config): Apply dotted tuple support for rustflags (rust-lang/cargo#17605)
- [beta-1.100] fix: check crate type when pruning `-L` paths (rust-lang/cargo#17590)


Fixes #164086
@rustbot rustbot added this to the 1.100.0 milestone Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cfg-expr Area: Platform cfg expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants