Repository navigation
Conversation
Add both ioctls, their argument structs and associated flags, sharing definitions between Linux and Android. Keep PAGE_IS_GUARD and PAGE_IS_ACCESSED Linux-only because Bionic does not expose them yet. Add semver entries and test exclusions for older headers. Sources: https://github.com/torvalds/linux/blob/3389648819829299517a8d482fda213fd7166a2c/include/uapi/linux/fs.h https://android.googlesource.com/platform/bionic/+/731631f300090436d7f5df80d50b6275c8c60a93/libc/kernel/uapi/linux/fs.h
Collaborator
|
Some changes occurred in an Android module cc @maurer |
rustbot
added
O-android
O-linux
O-linux-like
S-waiting-on-review
stable-nominated
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
PROCMAP_QUERYandPAGEMAP_SCAN, their structs and flags for Linuxand Android. Common definitions are shared.
PAGE_IS_GUARDandPAGE_IS_ACCESSEDstay Linux-only.I saw #4573 about removing Linux UAPI bindings from libc. Since additions like #5224 and #5145 have been merged since then, I figured this was worth proposing too. Totally fine to close this if adding more goes against that direction.
Testing:
ci/run.sh aarch64-unknown-linux-gnupassed using therepo's Ubuntu 26.04 Docker setup, including all three feature
configurations and docs.
Also tried NDK 30: it hits unrelated
SYS_arch_specific_syscalland_PATH_DEFPATHincompatibilities in the existing tests.Checklist
libc-test/semverhave been updated*LASTor*MAXhave the standarddoc comment (not applicable)
cargo test -p libc-test --target mytarget),especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated