[asder8215]

From @psumbera's comment here: rust-lang/rust#157144 (comment)

Solaris defines _PATH_BSHELL in <paths.h> as "/usr/bin/sh", but it does not define _PATH_DEFPATH.

For rust-lang/libc, it would be useful to add both Solaris _PATH_BSHELL and _CS_PATH (65). One caveat: the existing Rust Solaris confstr binding links to __confstr_xpg7, whereas Solaris execvp uses the mode-sensitive base confstr. Thus simply adding Solaris to the existing libc::confstr branch would select the XPG7 path and would not exactly reproduce current execvp behavior.

Oracle's documentation also confirms that the ENOEXEC shell depends on the caller's conformance mode: execvp(2) and standards(7).

From the rustc book, it seems like we only support Solaris targets running on Solaris 11.4. I assume that means that we don't need to worry about the mode-sensitive based confstr?

I also realized I forgot to check Illumos for how they handle _PATH_BSHELL/_PATH_DEFPATH. They have both a _PATH_DEFPATH, which uses "/usr/ccs/bin:/usr/bin:/bin", and a _PATH_BSHELL, which the value of _PATH_BSHELL is consistent with what @psumbera said. You can see the value it's set to in usr/src/head/paths.h; the _PATH_BSHELL is used in its execvp implementation in usr/src/lib/libc/port/gen/execvp.c (which also seems consistent with what @psumbera said!).

Since both use the same _PATH_BSHELL and _CS_PATH I put it in the solarish/mod.rs file. I hope that's fine?

Please let me know if I'm misunderstanding anything or if there are any issues with this PR @psumbera

Edit: _PATH_DEFPATH exists on illumos (missed it earlier).

[rustbot]

Some changes occurred in a solarish module

cc @jclulow, @pfmooney

[psumbera]

The code changes look correct to me. _CS_PATH has the same value on Solaris and illumos, and both define _PATH_BSHELL as "/usr/bin/sh", so placing them in solarish/mod.rs makes sense.

Two small corrections to the description:

1. Supporting Solaris 11.4 does not mean that mode-sensitive confstr behavior can be ignored. The default and XPG conformance modes both exist on Solaris 11.4. This does not affect adding _CS_PATH, since _CS_PATH is only the numeric selector; the selected confstr symbol/process mode determines the returned value.
2. illumos does define _PATH_DEFPATH, currently as "/usr/ccs/bin:/usr/bin:/bin" (paths.h). Its execvp implementation does not use that constant directly for the unset-PATH fallback, however, so it is not needed for this particular change.

[asder8215]

2. illumos does define _PATH_DEFPATH, currently as "/usr/ccs/bin:/usr/bin:/bin" (paths.h). Its execvp implementation does not use that constant directly for the unset-PATH fallback, however, so it is not needed for this particular change.

You're right, I missed that.

I'll add it _PATH_DEFPATH just for consistency with other platforms.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[asder8215]

Completely forgot to do this
@rustbot label stable-nominated