Repository navigation
Update ACP issue template - #870
Open
clarfonthey wants to merge 1 commit into
Open
clarfonthey wants to merge 1 commit into
clarfonthey wants to merge 1 commit into
Conversation
clarfonthey
force-pushed
the
acp-template
branch
from
August 30, 2026 00:34
d61dc6e to
fe0d6a2
Compare
ChrisDenton
reviewed
Aug 30, 2026
clarfonthey
force-pushed
the
acp-template
branch
from
August 30, 2026 03:04
fe0d6a2 to
f2296b0
Compare
| - We think this specific solution looks roughly right, approved, you or someone else should implement this. (Further review will still happen on the subsequent implementation PR.) | ||
| - We're not sure this is the right solution, and the alternatives or other materials don't give us enough information to be sure about that. Here are some questions we have that aren't answered, or rough ideas about alternatives we'd want to see discussed. | ||
|
|
||
| If we do think an API is worth implementing, we'll add the `ACP-accepted` label to your issue, at which point a [tracking issue] on the `rust-lang/rust` repository should be opened. Once the tracking issue exists, we'll close the issue as completed. |
Member
There was a problem hiding this comment.
Suggested change
| If we do think an API is worth implementing, we'll add the `ACP-accepted` label to your issue, at which point a [tracking issue] on the `rust-lang/rust` repository should be opened. Once the tracking issue exists, we'll close the issue as completed. | |
| If we do think an API is worth implementing, we'll add the `ACP-accepted` label to your issue, at which point you should open a [tracking issue] on the `rust-lang/rust` repository. Once the tracking issue exists, you can close the issue as completed. |
|
|
||
| [tracking issue]: https://github.com/rust-lang/rust/issues/new?assignees=&labels=C-tracking-issue%2C+T-libs&template=library_tracking_issue.md&title=Tracking+Issue+for+XXX | ||
|
|
||
| In general, we prefer that authors close their own ACPs instead of the team rejecting them, since generally, the solution to a problem is "not now/differently," not "never, in no possible way." However, if an ACP ends up being merged in some other form (e.g. a similar one is accepted) or an ACP cannot be done without breaking stability guarantees, we may close it for that reason. |
Member
There was a problem hiding this comment.
I don't think that we should have a framing like this on the ACP template, such that it shows up in every issue. Having a mention of how we close issues as the last thing someone sees in the template seems like it sets the wrong tone.
Contributor
Author
There was a problem hiding this comment.
Hmm, honestly, you're kind of right, and I think maybe we should also move some of this into a forge policy instead of being in the template itself.
clarfonthey
force-pushed
the
acp-template
branch
from
September 19, 2026 16:27
f2296b0 to
261778c
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Decided to merge the changes to the header directly to main, so we can at least fix the mention of libs-api while we debate other aspects of this. |
clarfonthey
force-pushed
the
acp-template
branch
from
September 19, 2026 16:28
261778c to
94b5a8f
Compare
clarfonthey
force-pushed
the
acp-template
branch
from
September 30, 2026 22:58
94b5a8f to
74cbef6
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #547.
Also fixes a label change post RFC 3984. Figures that the one repo I forgot to check was this one…