Repository navigation
ci: Resolve most zizmor findings as of zizmor@1.32.0 - #3544
Draft
hashcatHitman wants to merge 21 commits into
Draft
hashcatHitman wants to merge 21 commits into
hashcatHitman wants to merge 21 commits into
Conversation
See: https://github.com/actions/checkout/releases/tag/v4.4.0 This is the same version we're already implicitly using. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/actions/setup-node/releases/tag/v4.4.0 This is the same version we're already implicitly using. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/JamesIves/github-pages-deploy-action/releases/tag/3.7.1 This is the same version we're already using. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/mathieudutour/github-tag-action/releases/tag/v6.2 This is the same version we're already using. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/peter-evans/create-pull-request/releases/tag/v5.0.3 This is the same version we're already implicitly using. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/taiki-e/install-action/releases/tag/v1.17.3 This is the same version we're already implicitly using. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/chainguard-dev/actions/releases/tag/v1.7.2 Instead of directly tracking the main development branch, this uses the newest actual release, which is only 4 days old. At the time of writing, this just so happens to *also* be the *exact* commit `main` points to, so this is "the same version we're already using". Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Member
Author
|
r? crabwatch |
Member
Author
|
I'm seeing the same CI failures on other PRs, so I'm pretty sure those aren't my doing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pursuit of getting more
zizmorlints enforced acrossrust-langrepos throughcrabwatch, this PR fixes mostzizmorfindings as ofzizmor@1.32.0, using theauditorpersona. The lints that actually fired per-persona level are:regularpersona findings:artipackedexcessive-permissions(See also: Solve theexcessive-permissionslint crabwatch#97)template-injectionunpinned-usesdangerous-triggers(Needs careful consideration. See also: Solve thedangerous-triggerslint crabwatch#99)unpinned-images(Only shows up in acargo-distworkflow)use-trusted-publishing(Should be covered by Switch to trusted publishing #3517)pedanticpersona findings:regularexcessive-permissions(See also: Solve theexcessive-permissionslint crabwatch#97)template-injectionstale-action-refsundocumented-permissionsanonymous-definition(Because coming up with names is hard and there is minimal benefit to this)superfluous-actions(Because I'm not interested in replacingpeter-evans/create-pull-requestwithgh pr createright now (but someone else is more than welcome to))concurrency-limits(Due to concerns about special cases. See also: Determine special cases forconcurrency-limitscrabwatch#107)auditorpersona findings:pedanticThis repo is a special case in my quest due to the use of
cargo-dist. I will have to revisit it before I can actually change the policy to enforce any of this. See: rust-lang/crabwatch#145. So for the purposes of this PR, any lint that has been solved everywhere except in.github/workflows/release.ymlis considered "solved" for now. See the other branch where I addedignorecomments to all the issues flagged in that workflow: hashcatHitman/rust-bindgen@zizmor-ignore-cargo-distAlso, I don't know when you last used it, but in my experience,
.github/workflows/bump-version.ymljust doesn't work unless you upgrade to a newer version oftaiki-e/install-action. I just used the newestv2version. But I didn't keep that update as part of this PR; that's for you to decide you want to do separately.The hash pin format is supported by tools like Dependabot and Renovate, which can update the pinned hashes and their associated comments. If you'd like help setting either of those up, let me know which you prefer, and if you'd like it in this PR or a new one. By default, I'd assume to set it up to only update GitHub Actions.