Repository navigation
new lint: manual_lowest_one - #17954
Closed
raushan728 wants to merge 1 commit into
Closed
raushan728 wants to merge 1 commit into
raushan728 wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-community-reviews
Collaborator
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. |
This comment has been minimized.
This comment has been minimized.
raushan728
force-pushed
the
feat/manual-lowest-one
branch
from
November 5, 2026 12:49
bebf36a to
527043b
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
rustbot
removed
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16986
Adds
manual_lowest_one, which suggestsx.lowest_one()forif x == 0 { None } else { Some(x.trailing_zeros()) }(and the!= 0/ swapped forms).Only primitive integers are linted, with MSRV 1.97.0.
changelog: new lint: [
manual_lowest_one]