Skip to content

Regression building proc-macro2 1.0.59 with nightly-2023-06-28 #113152

New issue
New issue
Closed
Closed
Regression building proc-macro2 1.0.59 with nightly-2023-06-28#113152
Labels
C-discussionCategory: Discussion or questions that doesn't represent real issues.

Description

@davidv1992
davidv1992
opened on Jun 29, 2023

How to fix it:

update proc-macro2 to the latest version.

proc_macro2 1.0.59 Fails to build with nightly-2023-06-28 but succeeds building on nightly-2023-06-27

Code

Create a new binary project with cargo new --bin buildtest

add dependency on proc_macro2 with proc_macro feature:

[dependencies]
proc-macro2 = { version = "=1.0.59", features=["default", "proc-macro"] }

Try building binary with cargo build, it will not work and fail with the following error:

error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /home/david/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.59/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `proc-macro2` (lib) due to previous error

Version it worked on

It most recently worked on: nightly-2023-06-27

Version with regression

rustc --version --verbose:

rustc 1.72.0-nightly (5bd28f5ea 2023-06-28)
binary: rustc
commit-hash: 5bd28f5eac1ba3569bfa8d49ec3f5acbdfdff7a0
commit-date: 2023-06-28
host: x86_64-unknown-linux-gnu
release: 1.72.0-nightly
LLVM version: 16.0.5

@rustbot modify labels: +regression-from-stable-to-nightly -regression-untriaged

Activity

  1. davidv1992
    added
    C-bugCategory: This is a bug.
    regression-untriagedUntriaged performance or correctness regression.
    on Jun 29, 2023
  2. rustbot
    added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.
    and removed
    regression-untriagedUntriaged performance or correctness regression.
    on Jun 29, 2023

  3. Noratrieb commented on Jun 29, 2023

    @Noratrieb
    Noratrieb
    on Jun 29, 2023
    Member

    #111571 changed the feature gate. proc-macro2 is enabling the nightly feature that doesn't exist anymore. This is an issue with the proc-macro2 crate (cc @dtolnay).

    I'm going to leave this issue open for now so that other people can see it.

  4. Noratrieb
    added
    C-discussionCategory: Discussion or questions that doesn't represent real issues.
    and removed
    regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.
    C-bugCategory: This is a bug.
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Jun 29, 2023
  5. Noratrieb
    pinned this issue on Jun 29, 2023

  6. Nemo157 commented on Jun 29, 2023

    @Nemo157
    Nemo157
    on Jun 29, 2023
    Contributor

    It is fixed in proc-macro2 1.0.60+ dtolnay/proc-macro2#391

  7. davidv1992 commented on Jun 29, 2023

    @davidv1992
    davidv1992
    on Jun 29, 2023
    ContributorAuthor

    Good to know it is intended breakage, will upgrade then.

  8. dtolnay
    closed this as completedon Jun 29, 2023
  9. asomers-ax
    added a commit that references this issue on Jun 29, 2023

    Fix the build with the latest nightly compiler.

    39b1284

  10. 79 remaining items

  11. yohcop
    added a commit that references this issue on Sep 12, 2023

    Bump proc-macro2 from 1.0.50 to 1.0.66 in /src/bare-metal/microcontro… (

    5afb5b5
  12. Ameobea
    added a commit that references this issue on Sep 23, 2023

    Bump some dependencies to fix build issues

    62b83d3
  13. jamiepine
    added a commit that references this issue on Oct 10, 2023

    fix blog post branch merge conflicts (#1459)

    60eb7fb
  14. sebastiencs
    added 2 commits that reference this issue on Oct 13, 2023

    Fix compilation on latest nightly toolchain

    56cce86

    Fix compilation on latest nightly toolchain

    015de34
  15. woshilapin
    added a commit that references this issue on Oct 24, 2023

    style(clippy): fix all new clippy errors with 'rustc:1.73.0'

    fa548c1
  16. orhun
    added a commit that references this issue on Oct 27, 2023

    style(clippy): fix all new clippy errors with 'rustc:1.73.0' (#111)

    6182434
  17. 0xLyte
    added a commit that references this issue on Nov 23, 2023

    Force rust nightly for the examples and bump of the dependencies vers…

    73444f2
  18. nya3jp
    added a commit that references this issue on Nov 29, 2023

    Bump proc-macro2 to 1.0.60

    d4b781c
  19. hikalium
    added a commit that references this issue on Dec 19, 2023

    Update proc-macro2

    5069a94
  20. rksm
    added 2 commits that reference this issue on Dec 26, 2023

    fix CI failure

    25d40bb

    fix CI failure

    98569c1
  21. epwalsh
    added a commit that references this issue on Jan 7, 2024

    fix sending a message from a rust client to a python worker with redi…

    dd3a43e
  22. wineway
    added a commit that references this issue on Feb 2, 2024

    fix compiled on `proc_macro_span_shrink` was removed

    4b93461
  23. 5eqn
    added a commit that references this issue on Nov 11, 2024

    Update proc-macro2 pin

    3fdc1e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-discussionCategory: Discussion or questions that doesn't represent real issues.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions