regression: std no longer in toolchain dir #132202

Activity

1. Mark-Simulacrum

   added

   regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   on Oct 26, 2024
2. Mark-Simulacrum

   added this to the 1.83.0 milestone on Oct 26, 2024
3. rustbot

   added

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Oct 26, 2024
4. saethlin

   removed

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Oct 27, 2024
5. apiraino commented on Oct 30, 2024

   

   apiraino

   on Oct 30, 2024

   Contributor

   More actions

   I quickly skimmed at the most recent merges with relnotes and didn't find anything from {t-libs,-api} about that. Very likely have missed that, just wanted to check if it's tagged for the changelog
6. apiraino

   removed

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   on Oct 30, 2024
7. jieyouxu commented on Oct 30, 2024

   

   jieyouxu

   on Oct 30, 2024

   Last edited by jieyouxu

   Member

   More actions

   I quickly skimmed at the most recent merges with relnotes and didn't find anything from {t-libs,-api} about that. Very likely have missed that, just wanted to check if it's tagged for the changelog

   As discussed in https://rust-lang.zulipchat.com/#narrow/channel/245100-t-compiler.2Fwg-prioritization.2Falerts/topic/.23132202.20regression.3A.20std.20no.20longer.20in.20toolchain.20dir, this is probably T-bootstrap (and maybe weakly T-compiler) change from #131188. But yes, we should probably add a compat note.

   cc @Kobzol as you may know more about this, but I suspect the prefer-dynamic crate was relying on undocumented unguaranteed behavior and that this isn't considered a "breakage" in the strict sense.

   EDIT: nevermind @bjorn3 already commented on the prefer-dynamic crate WilliamVenner/prefer-dynamic#2, oops.

   👍React with 👍1Reacted by apiraino
8. jieyouxu

   added

   T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

   on Oct 30, 2024
9. Kobzol commented on Oct 30, 2024

   

   Kobzol

   on Oct 30, 2024

   Last edited by Kobzol

   Member

   More actions

   Yeah I think that if anyone depended on libstd.so within the lib directory, it was an instance of Hyrum's Law.

   😄React with 😄1Reacted by 许杰友 Jieyou Xu (Joe)
10. cuviper commented on Nov 22, 2024

    

    cuviper

    on Nov 22, 2024

    Member

    More actions

    This will be documented as a compat note via #133352.
11. jieyouxu commented on Nov 30, 2024

    

    jieyouxu

    on Nov 30, 2024

    Member

    More actions

    I think this can be closed since 1.83.0 is already released containing said compat notes?
12. apiraino commented on Dec 2, 2024

    

    apiraino

    on Dec 2, 2024

    Contributor

    More actions

    I think so, so I will go and close this one.

    This thing of closing regressions accepted for one reason or another was mentioned on Zulip but I'd want to document this reasoning in some place to make it more "official" and discoverable.
13. apiraino

    closed this as completedon Dec 2, 2024