Skip to content

tests/ui/issues/issue-2170-exe.rs is ineffective #157477

New issue
New issue
Closed
#157596
Closed
tests/ui/issues/issue-2170-exe.rs is ineffective#157477
#157596
Assignees
arshalaromal
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@jieyouxu
jieyouxu
opened on Jun 5, 2026

Remark (not for this PR): this test looks... ineffective?

Issue was #2170. cf. #2177 as well.

Test history: https://github.com/rust-lang/rust/commits/e41029d236c940e7ffb08c43e6cee23025ba029d/src/test/run-pass/issue2170exe.rs

NB: renamed to tests/ui/cross-crate/link-extern-crate-with-drop-type.rs in #157447.

I'd say probably yeet it.

Activity

  1. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 5, 2026
  2. jieyouxu
    added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    C-bugCategory: This is a bug.
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
    on Jun 5, 2026

  3. jieyouxu commented on Jun 5, 2026

    @jieyouxu
    jieyouxu
    on Jun 5, 2026 · Hidden as outdated
    Author

  4. bjorn3 commented on Jun 5, 2026

    @bjorn3
    bjorn3
    on Jun 5, 2026
    Member

    I'd say probably yeet it.

    Agreed. It was a test for certain behavior around resources, but we haven't had resources as first class concept in almost 15 years.

  5. lms0806 commented on Jun 6, 2026

    @lms0806
    lms0806
    on Jun 6, 2026
    Contributor

    Should this issue be handled at #157447?

  6. jieyouxu commented on Jun 6, 2026

    @jieyouxu
    jieyouxu
    on Jun 6, 2026
    MemberAuthor

    I rather that PR just do one thing (the renames and moves), we can yeet this test after.

  7. arshalaromal commented on Jun 7, 2026

    @arshalaromal
    arshalaromal
    on Jun 7, 2026
    Contributor

    i can work on this after #157447 merges, if that’s alright

  8. arshalaromal commented on Jun 8, 2026

    @arshalaromal
    arshalaromal
    on Jun 8, 2026
    Contributor

    @rustbot claim

  9. rustbot
    assigned
    arshalaromal
    on Jun 8, 2026
  10. JonathanBrouwer
    added 2 commits that reference this issue on Jun 8, 2026

    Rollup merge of rust-lang#157596 - arshalaromal:remove-ineffective-te…

    f370bf0

    Rollup merge of rust-lang#157596 - arshalaromal:remove-ineffective-te…

    ab8dea7
  11. rust-bors
    closed this as completedin ab8dea7on Jun 8, 2026
  12. rust-timer
    added a commit that references this issue on Jun 8, 2026

    Unrolled build for #157596

    a774f1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions