Skip to content

tests/ui/issues/issue-29485.rs has a useless #[feature(recover)] #157478

New issue
New issue
Closed
#157486
Closed
tests/ui/issues/issue-29485.rs has a useless #[feature(recover)]#157478
#157486
Assignees
lms0806
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@jieyouxu
jieyouxu
opened on Jun 5, 2026

Remark (not for this PR): introduced in a17fb64, this #[feature(recover)] is (1) useless, as it's the outer attribute applied to the extern crate thus triggering unused_attributes but there's a #![allow(unused_attributes)] slapped in this test. And also #![feature(recover)] got stabilized in 1.9.

Originally posted by @jieyouxu in #157447 (comment)

NB: renamed to tests/ui/cross-crate/mut-ref-write-visible-after-unwind.rs in #157447.

Prob. (1) remove recover feature attr, (2) remove unused attr allow.

Activity

  1. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Jun 5, 2026
  2. jieyouxu
    added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 5, 2026
  3. jieyouxu
    changed the title [-]`tests/ui/cross-crate/mut-ref-write-visible-after-unwind.rs` has a useless `#[feature(recover)]`[/-] [+]`tests/ui/issues/issue-29485.rs` has a useless `#[feature(recover)]`[/+] on Jun 5, 2026

  4. jieyouxu commented on Jun 5, 2026

    @jieyouxu
    jieyouxu
    on Jun 5, 2026
    MemberAuthor

    Probably bundle into same PR w/ #157477

  5. lms0806 commented on Jun 5, 2026

    @lms0806
    lms0806
    on Jun 5, 2026
    Contributor

    @rustbot claim

  6. rustbot
    assigned
    lms0806
    on Jun 5, 2026
  7. JonathanBrouwer
    added a commit that references this issue on Jun 5, 2026

    Rollup merge of rust-lang#157486 - lms0806:issue_157478, r=JonathanBr…

    0a37e80
  8. jhpratt
    added 2 commits that reference this issue on Jun 5, 2026

    Rollup merge of rust-lang#157486 - lms0806:issue_157478, r=JonathanBr…

    cab19bd

    Rollup merge of rust-lang#157486 - lms0806:issue_157478, r=JonathanBr…

    6169a62
  9. GuillaumeGomez
    added a commit that references this issue on Jun 5, 2026

    Rollup merge of rust-lang#157486 - lms0806:issue_157478, r=JonathanBr…

    cd56fd8
  10. rust-bors
    closed this as completedin #157486on Jun 5, 2026
  11. rust-timer
    added a commit that references this issue on Jun 5, 2026

    Unrolled build for #157486

    c83112f
  12. github-actions
    added a commit that references this issue on Jun 8, 2026

    Rollup merge of #157486 - lms0806:issue_157478, r=JonathanBrouwer

    d25cca2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions