Skip to content

Tidy CTFE/miri #53596

New issue
New issue
Closed
Closed
Tidy CTFE/miri#53596
Labels
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Description

@RalfJung
RalfJung
opened on Aug 22, 2018

CTFE/miri (the code in src/librustc/mir/interpret and src/librustc_mir/interpret) is currently exempt from tidy:

rust/src/tools/tidy/src/lib.rs

Lines 79 to 80 in 24bc544

"src/librustc/mir/interpret",
"src/librustc_mir/interpret",

That should not be hard to fix, it is mostly a matter of adding a license header everywhere and breaking long lines into less than 100 characters. Basically, start by removing the above two lines from tidy, and then ./x.py --stage 1 test tidy will tell you all that needs fixing.

Activity

  1. RalfJung
    added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    on Aug 22, 2018

  2. lovesegfault commented on Aug 22, 2018

    @lovesegfault
    lovesegfault
    on Aug 22, 2018
    Contributor

    @RalfJung I'd like to take this, if that's OK :)

  3. RalfJung commented on Aug 22, 2018

    @RalfJung
    RalfJung
    on Aug 22, 2018
    MemberAuthor

    That's perfect :) Let me know if you need anything!

  4. lovesegfault commented on Aug 22, 2018

    @lovesegfault
    lovesegfault
    on Aug 22, 2018
    Contributor

    @RalfJung Is this the correct license header?

    // Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

  5. RalfJung commented on Aug 22, 2018

    @RalfJung
    RalfJung
    on Aug 22, 2018
    MemberAuthor

    Yeah that looks all right (you first had a different year? My email notification says something else^^)

  6. lovesegfault commented on Aug 22, 2018

    @lovesegfault
    lovesegfault
    on Aug 22, 2018
    Contributor

    @RalfJung Yeah, I had 2013-2015 before, since I just pasted it from some random file, but I updated it to just say 2018

  7. memoryruins commented on Aug 24, 2018

    @memoryruins
    memoryruins
    on Aug 24, 2018
    Contributor

    Impeccable timing #53617 #53654

  8. RalfJung commented on Aug 24, 2018

    @RalfJung
    RalfJung
    on Aug 24, 2018
    MemberAuthor

    Well, yeah^^

  9. lovesegfault commented on Aug 24, 2018

    @lovesegfault
    lovesegfault
    on Aug 24, 2018
    Contributor

    Hehehe

  10. bors
    added a commit that references this issue on Aug 25, 2018

    Auto merge of #53609 - bemeurer:tidy-ctfe, r=RalfJung

    e41f411
  11. bors
    closed this as completedin #53609on Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions