Repository navigation
Each call of tcx.{declared_,explicit_,}predicates_of clones the GenericPredicate struct, which includes a Vec. #54274
Description
Did we forget to intern/Rc it? cc @nikomatsakis @arielb1 @nnethercote
Did we forget to intern/Rc it? cc @nikomatsakis @arielb1 @nnethercote
Activity
nnethercote commentedon Sep 18, 2018
I can't find a function or method called
generic_predicates. What is the code location?[-]Each call of tcx.generic_predicates clones the GenericPredicate struct, which includes a Vec.[/-][+]Each call of tcx.{declared_,explicit_,}predicates_of clones the GenericPredicate struct, which includes a Vec.[/+]eddyb commentedon Sep 18, 2018
Sorry, I mistyped. I meant all the functions in
rustc::ty::querythat returnGenericPredicates.nikomatsakis commentedon Sep 18, 2018
I've noticed this before but never filed an issue. I think we probably ought to
Rc, yes.nikomatsakis commentedon Sep 18, 2018
(Or intern)
nnethercote commentedon Nov 8, 2018
#55778 fixes some of these, the ones that show up in profiles. There are still a couple more that were more annoying to fix.