Tracking issue for feature extern_crate_item_prelude #55599

Activity

1. petrochenkov

   added

   T-langRelevant to the language teamRelevant to the language team

   B-unstableBlocker: Implemented in the nightly compiler and unstable.Blocker: Implemented in the nightly compiler and unstable.

   C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFC

   F-rust_2018_preview`#![feature(rust_2018_preview)]``#![feature(rust_2018_preview)]`

   on Nov 1, 2018
2. Nemo157 commented on Nov 3, 2018

   

   Nemo157

   on Nov 3, 2018

   Last edited by Nemo157

   Contributor

   More actions

   Is this intended to be stable for the initial 2018 release? It seems important for a nice experience with proc-macros (otherwise you must use crate::proc_macro everywhere).

   If not, this appears to have no forward-compat warning when building under 2015, which causes a failure to migrate with cargo fix:

   error[E0658]: use of extern prelude names introduced with `extern crate` items is unstable (see issue #54658)
     --> interp-macros/src/lib.rs:12:5
      |
   12 | use proc_macro::TokenStream;
      |     ^^^^^^^^^^
      |
      = help: add #![feature(extern_crate_item_prelude)] to the crate attributes to enable

   👍React with 👍2Reacted by Carol (Nichols || Goulding) and Dainslef Tei
3. SimonSapin commented on Nov 4, 2018

   

   SimonSapin

   on Nov 4, 2018

   Contributor

   More actions

   this appears to have no forward-compat warning

   I’ve also hit this and filed #55592
4. steveklabnik commented on Nov 7, 2018

   

   steveklabnik

   on Nov 7, 2018

   Contributor

   More actions

   Knowing if this will ship in 1.31 or not is important for the book, for the reasons that @Nemo157 mentioned. Could we maybe get an answer here?
5. SimonSapin commented on Nov 7, 2018

   

   SimonSapin

   on Nov 7, 2018

   Contributor

   More actions

   @petrochenkov, @rust-lang/lang Are there any blockers for stabilizing this feature? How do you feel about backporting its stabilization to 1.31 beta? Should FCP be proposed now?
6. SimonSapin commented on Nov 7, 2018

   

   SimonSapin

   on Nov 7, 2018

   Contributor

   More actions

   In servo/servo#22086 I’ve migrated a number of Servo crates to the 2018 editions, but I left out proc-macro and plugin crates in part because of this issue (or lack of other good way to deal with crate dependencies not known to Cargo).
7. petrochenkov

   self-assigned this

   on Nov 14, 2018
8. petrochenkov commented on Nov 14, 2018

   

   petrochenkov

   on Nov 14, 2018

   Last edited by petrochenkov

   ContributorAuthor

   More actions

   @aturon and @steveklabnik wanted to stabilize this for the edition release as well (on #edition-planning discord channel).

   This should be ready for stabilization and backport to 1.31 beta once #55884 lands (or some fixes for this feature are extracted from that PR).
   I'll prepare a stabilization report.
9. bors

   added a commit that references this issue on Nov 21, 2018

   Auto merge of #56032 - petrochenkov:stabecip, r=nikomatsakis

   ...

   780658a
10. bors

    closed this as completedin #56032on Nov 21, 2018
11. fmease

    added

    A-edition-2018Area: The 2018 editionArea: The 2018 edition

    on Dec 21, 2024