Repository navigation
Fix: mark relevant spans (ex: ident.span) with macro expansion context #66095
Description
In #65830 it was discovered that hir::Item.ident.span isn't marked with_ctxt of being part of a macro expansion. This had two effects that we saw there:
- error messages don't include the "in this macro invocation" hints
- cases where the dead_code error was suppressed because of foreign macros were no longer suppressed
To solve that there, we're going to just use the old behavior when we're in the middle of a macro expansion already, so we don't use the un-marked span. As @estebank suggested, we should probably clean this up in a separate change.
Activity
Quantumplation commentedon Nov 6, 2019
@estebank when you get a chance could you (or someone else) provide some light mentorship here?
Specifically,