Tracking Issue for binary heap retain #71503

Activity

1. arlopurcell

   added

   C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFC

   on Apr 24, 2020
2. jonas-schievink

   added

   A-collectionsArea: `std::collections` (prefer A-binaryheap, A-btree, A-hashtable, A-linkedlist, A-vecdeque)Area: `std::collections` (prefer A-binaryheap, A-btree, A-hashtable, A-linkedlist, A-vecdeque)

   B-unstableBlocker: Implemented in the nightly compiler and unstable.Blocker: Implemented in the nightly compiler and unstable.

   T-libs-api[DEPRECATED; DO NOT USE][DEPRECATED; DO NOT USE]

   on Apr 24, 2020
3. KodrAus

   added

   I-nominated

   Libs-SmallLibs issues that are considered "small" or self-containedLibs issues that are considered "small" or self-contained

   I-libs-radarLibs issues that are tracked on the team's radar.Libs issues that are tracked on the team's radar.

   on Jul 29, 2020
4. KodrAus commented on Oct 30, 2020

   

   KodrAus

   on Oct 30, 2020

   Contributor

   More actions

   We discussed this at the recent Libs meeting and had a question about taking &T rather than &mut T. In the end we thought keeping consistent with Vec and not having to think about resorting afterwards made the &T item type appropriate.

   If anybody is keen to open a stabilization PR we can kick off a FCP!
5. KodrAus

   removed

   I-nominated

   on Oct 30, 2020
6. Dylan-DPC-zz

   added a commit that references this issue on Apr 22, 2021

   Rollup merge of rust-lang#78681 - m-ou-se:binary-heap-retain, r=Amanieu

   ...

   d6e5bba
7. bors

   added a commit that references this issue on Apr 23, 2021

   Auto merge of rust-lang#78681 - m-ou-se:binary-heap-retain, r=Amanieu

   ...

   f4a8cf0
8. JohnTitor commented on Jul 21, 2022

   

   JohnTitor

   on Jul 21, 2022

   Member

   More actions

   If anybody is keen to open a stabilization PR we can kick off a FCP!

   @rust-lang/libs-api May I ask to kick off a FCP? Stabilizing it will unblock rust-lang/rust-clippy#9059.
9. Amanieu commented on Jul 21, 2022

   

   Amanieu

   on Jul 21, 2022

   Member

   More actions

   @rfcbot fcp merge
10. rfcbot commented on Jul 21, 2022

    

    rfcbot

    on Jul 21, 2022

    Last edited by rfcbot

    More actions

    Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

    • @Amanieu
    • @BurntSushi
    • @dtolnay
    • @joshtriplett
    • @m-ou-se
    • @yaahc

    Concerns:

    • &mut resolved by Tracking Issue for binary heap retain #71503 (comment)
    • predicate panic can leave heap in invalid state resolved by Tracking Issue for binary heap retain #71503 (comment)

    Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    See this document for info about what commands tagged team members can give me.
11. rfcbot

    added

    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.

    on Jul 21, 2022
12. 22 remaining items

    Load more

13. rfcbot commented on Mar 14, 2023

    

    rfcbot

    on Mar 14, 2023

    More actions

    🔔 This is now entering its final comment period, as per the review above. 🔔
14. rfcbot

    added

    finished-final-comment-periodThe final comment period is finished for this PR / Issue.The final comment period is finished for this PR / Issue.

    to-announceAnnounce this issue on triage meetingAnnounce this issue on triage meeting

    and removed

    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.In the final comment period and will be merged soon unless new substantive objections are raised.

    on Mar 24, 2023
15. rfcbot commented on Mar 24, 2023

    

    rfcbot

    on Mar 24, 2023

    More actions

    The final comment period, with a disposition to merge, as per the review above, is now complete.

    As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

    This will be merged soon.
16. Amanieu

    added a commit that references this issue on Mar 28, 2023

    Stabilize `binary_heap_retain`

    ...

    c972a42
17. apiraino

    removed

    to-announceAnnounce this issue on triage meetingAnnounce this issue on triage meeting

    on Mar 30, 2023
18. bors

    added a commit that references this issue on Apr 2, 2023

    Auto merge of rust-lang#109701 - Amanieu:binaryheap_retain, r=ChrisDe…

    ...

    637d7fd
19. m-ou-se

    closed this as completedon Apr 4, 2023
20. thomcc

    added a commit that references this issue on May 31, 2023

    Rollup merge of #106918 - dtolnay:heapretain, r=the8472

    ...

    db142f8
21. dtolnay

    removed

    I-libs-api-nominated[DEPRECATED; DO NOT USE][DEPRECATED; DO NOT USE]

    on Sep 28, 2023
22. clarfonthey

    added

    I-libs-radarLibs issues that are tracked on the team's radar.Libs issues that are tracked on the team's radar.

    and removed

    I-libs-radarLibs issues that are tracked on the team's radar.Libs issues that are tracked on the team's radar.

    on Oct 22, 2026
23. clarfonthey

    added

    A-binaryheapArea: `std::collections::BinaryHeap`Area: `std::collections::BinaryHeap`

    and removed

    A-collectionsArea: `std::collections` (prefer A-binaryheap, A-btree, A-hashtable, A-linkedlist, A-vecdeque)Area: `std::collections` (prefer A-binaryheap, A-btree, A-hashtable, A-linkedlist, A-vecdeque)

    on Nov 2, 2026