Possible regression with #[rustfmt::skip] #78488

Activity

1. rustbot

   added

   regression-from-stable-to-stablePerformance or correctness regression from one stable version to another.Performance or correctness regression from one stable version to another.

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   on Oct 28, 2020
2. ehuss commented on Oct 28, 2020

   

   ehuss

   on Oct 28, 2020

   Contributor

   More actions

   @steveklabnik I believe this was changed in 1.44 probably via #69838. Do you happen to know which version the reporter was using? 1.44 or newer should build ok.

   There are still some oddities with inner tool attributes like #74087, so it is possible it could be that.
3. steveklabnik commented on Oct 28, 2020

   

   steveklabnik

   on Oct 28, 2020

   ContributorAuthor

   More actions

   I don't know, but let's see if they can tell us: @dwarburt and @tarcieri (as well as @krisfris, who gave a 👍 on tony's issue), what Rust versions are you using?
4. tarcieri commented on Oct 28, 2020

   

   tarcieri

   on Oct 28, 2020

   Contributor

   More actions

   The main failure I have handy is 1.41.0:

   https://github.com/RustSec/rustsec-crate/runs/1318970855?check_suite_focus=true
5. dwarburt commented on Oct 28, 2020

   

   dwarburt

   on Oct 28, 2020

   More actions

   I'm using the toolchain that the brave-browser build scripts downloads

   ✔ ~/git/fork/brave-browser [master|✚ 1]$ ./src/brave/build/rustup/0.1.4/bin/rustc --version
   rustc 1.47.0 (18bf6b4f0 2020-10-07)
   ✔ ~/git/fork/brave-browser [master|✚ 1]$ 
   
6. camelid

   added

   A-attributesArea: Attributes (`#[…]`, `#![…]`)Area: Attributes (`#[…]`, `#![…]`)

   A-rustfmt

   on Oct 28, 2020
7. djc commented on Nov 3, 2020

   

   djc

   on Nov 3, 2020

   Contributor

   More actions

   I ran into this with 1.34.0 (which is the MSRV for err-derive, which used to depend on semver-parser via rustc-version).
8. steveklabnik commented on Nov 5, 2020

   

   steveklabnik

   on Nov 5, 2020

   ContributorAuthor

   More actions

   It appears this is actually my fault: steveklabnik/semver-parser#52 (comment)

   sorry about the noise.
9. steveklabnik

   closed this as completedon Nov 5, 2020
10. jyn514

    removed

    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

    on Feb 28, 2021
11. fmease

    added

    T-rustfmtRelevant to the rustfmt team, which will review and decide on the PR/issue.Relevant to the rustfmt team, which will review and decide on the PR/issue.

    and removed

    A-rustfmt

    on Oct 8, 2025