regression 1.49: macro_rules unexpected tokens #79908

Activity

1. Mark-Simulacrum

   added

   A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..)

   regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.

   on Dec 10, 2020
2. Mark-Simulacrum

   added this to the 1.49.0 milestone on Dec 10, 2020
3. rustbot

   added

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   on Dec 10, 2020
4. Aaron1011 commented on Dec 10, 2020

   

   Aaron1011

   on Dec 10, 2020

   Contributor

   More actions

   The fourier error looks like an old bug that was fixed by calebzulawski/fourier#17
5. Mark-Simulacrum commented on Dec 10, 2020

   

   Mark-Simulacrum

   on Dec 10, 2020

   MemberAuthor

   More actions

   https://crates.io/crates/fourier only lists 0.1.0 so we should probably nag @calebzulawski about a point release one more time :)
6. calebzulawski commented on Dec 10, 2020

   

   calebzulawski

   on Dec 10, 2020

   Member

   More actions

   Whoops, looks like I half-fixed it. One of my dependencies is too strict. It does look like the same error so probably not a regression...
7. Mark-Simulacrum commented on Dec 11, 2020

   

   Mark-Simulacrum

   on Dec 11, 2020

   MemberAuthor

   More actions

   cc @petrochenkov
8. Mark-Simulacrum

   added

   E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustcCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc

   E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example

   on Dec 11, 2020
9. camelid

   added

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   on Dec 11, 2020
10. camelid commented on Dec 16, 2020

    

    camelid

    on Dec 16, 2020

    Member

    More actions

    @apiraino and I both feel unclear about this: Is this a Rust regression or a regression in a library that was then picked up by Crater?
11. Mark-Simulacrum commented on Dec 16, 2020

    

    Mark-Simulacrum

    on Dec 16, 2020

    MemberAuthor

    More actions

    This is a regression in the Rust compiler.
12. camelid commented on Dec 16, 2020

    

    camelid

    on Dec 16, 2020

    Member

    More actions

    The tiger error seems to me like fallout from implementing inline_const. I'm guessing the issue is that it's expecting a block but immediately gets a literal. Not sure how this is supposed to behave though.

    ---

    Reposting the error here:

    [INFO] [stdout] error: expected expression, found keyword `const`
    [INFO] [stdout]    --> src/ir.rs:481:23
    [INFO] [stdout]     |
    [INFO] [stdout] 347 |     (exp $e:expr) => {
    [INFO] [stdout]     |          ------- while parsing argument for this `expr` macro fragment
    [INFO] [stdout] ...
    [INFO] [stdout] 481 |             stmt!(exp const 1);
    [INFO] [stdout]     |                       ^^^^^ expected expression
    [INFO] [stdout] 
    [INFO] [stdout] 
    [INFO] [stdout] error: expected expression, found keyword `const`
    [INFO] [stdout]    --> src/ir.rs:482:23
    [INFO] [stdout]     |
    [INFO] [stdout] 347 |     (exp $e:expr) => {
    [INFO] [stdout]     |          ------- while parsing argument for this `expr` macro fragment
    [INFO] [stdout] ...
    [INFO] [stdout] 482 |             stmt!(exp const 2);
    [INFO] [stdout]     |                       ^^^^^ expected expression
    [INFO] [stdout] 
    [INFO] [stdout] 
    [INFO] [stdout] error: expected expression, found keyword `const`
    [INFO] [stdout]    --> src/ir.rs:483:23
    [INFO] [stdout]     |
    [INFO] [stdout] 347 |     (exp $e:expr) => {
    [INFO] [stdout]     |          ------- while parsing argument for this `expr` macro fragment
    [INFO] [stdout] ...
    [INFO] [stdout] 483 |             stmt!(exp const 3);
    [INFO] [stdout]     |                       ^^^^^ expected expression
    [INFO] [stdout] 
    [INFO] [stdout] 
    [INFO] [stdout] error: aborting due to 3 previous errors
    
13. camelid commented on Dec 16, 2020

    

    camelid

    on Dec 16, 2020

    Member

    More actions

    But I'm not quite sure; the span seems potentially wrong.
14. 18 remaining items

    Load more
15. camelid

    removed their assignment

    on Dec 17, 2020
16. camelid commented on Dec 17, 2020

    

    camelid

    on Dec 17, 2020

    Member

    More actions

    Actually, I just noticed that petrochenkov responded to my message asking for help finding the code 😄

    👍React with 👍1Reacted by Léo Lanteri Thauvin

    😄React with 😄1Reacted by Léo Lanteri Thauvin
17. camelid

    self-assigned this

    on Dec 17, 2020
18. RalfJung

    added 2 commits that reference this issue on Dec 18, 2020

    Rollup merge of rust-lang#80135 - camelid:const-macro-nt, r=petrochenkov

    ...

    This issue will close once commit bd40604 is merged into the 'main' branch.

    bd40604

    Rollup merge of rust-lang#80135 - camelid:const-macro-nt, r=petrochenkov

    ...

    This issue will close once commit 9269995 is merged into the 'main' branch.

    9269995
19. bors

    closed this as completedin 9269995on Dec 18, 2020
20. camelid commented on Dec 18, 2020

    

    camelid

    on Dec 18, 2020

    Member

    More actions

    This should be fixed on the next nightly.
21. Mark-Simulacrum commented on Dec 18, 2020

    

    Mark-Simulacrum

    on Dec 18, 2020

    MemberAuthor

    More actions

    Reopening to track beta fix.

    👍React with 👍1Reacted by Noah Lev
22. Mark-Simulacrum

    reopened this on Dec 18, 2020
23. Mark-Simulacrum commented on Dec 27, 2020

    

    Mark-Simulacrum

    on Dec 27, 2020

    MemberAuthor

    More actions

    Should be backported to beta as part of #80417.

    👍React with 👍1Reacted by Noah Lev
24. camelid commented on Dec 29, 2020

    

    camelid

    on Dec 29, 2020

    Member

    More actions

    I think this can be closed as #80417 has been merged?

    👍React with 👍1Reacted by Léo Lanteri Thauvin
25. LeSeulArtichaut

    closed this as completedon Dec 29, 2020