Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
|
Error: Failed to set assignee to
Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I think the test runner just took too long? In any case, I finally had a bit more time for thorough testing and can confirm that it works without issues. My main goal was to actually enable nested offload functions in |
|
Our CI timeout is after 6hrs iirc, some of our runners regulary take over 3hrs. Just force-push to trigger a rerun, this might be a spurious failure. github CI is often a bit flaky. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
|
PR is rebased, checks are green and the new |
| _ => None, | ||
| }, | ||
| Annotatable::Stmt(stmt) => match &stmt.kind { | ||
| ast::StmtKind::Item(iitem) => match &iitem.kind { |
There was a problem hiding this comment.
Just for some code cleanup, can you deduplicate the two by first extracting the inner item from both branches?
Then you can handle the ItemKind::Fn case once. Also if let could be a bit nicer.
|
lgtm, minor some code feedback. Can you squash it to one or two commits terwards so the wip/fix comments are gone? There's also a bors command for it if you want. |
Related to #131513.
Allows annotating nested functions with
#[offload_kernel], similar to autodiff.Also fixes the error message when
#[offload_kernel]is used on anything other than functions.r? @ZuseZ4
(@Sa4dUs, ping)