Skip to content

Update cargo submodule - #163881

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
weihanglo:update-cargo
Oct 8, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
weihanglo:update-cargo

Conversation

@weihanglo

@weihanglo weihanglo commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

View all comments

15 commits in f3865b2a4d1acc5276f6b3c67d0e057f4dab3928..29c5daa1afc262323364e039bb70c83372cc702c
2026-09-29 19:58:08 +0000 to 2026-10-07 22:13:48 +0000

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2026
@rustbot

rustbot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

@weihanglo

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=1

@rust-bors

rust-bors Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 01febd5 has been tentatively approved by weihanglo

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 7, 2026
Update cargo submodule

11 commits in f3865b2a4d1acc5276f6b3c67d0e057f4dab3928..45c3aacf0e8dabdcdb6b7b518db100061d6367a7
2026-09-29 19:58:08 +0000 to 2026-10-06 16:29:08 +0000
- feat(pkgid-spec): Builtin package spec parsing and formatting (rust-lang/cargo#17539)
- feat(hints): support minimum optimization levels (rust-lang/cargo#17368)
- Use trusted publishing for Cargo crates (rust-lang/cargo#17426)
- feat(trim-paths): stabilize `profile.trim-paths` (rust-lang/cargo#17488)
- fix(pkgid): avoid panic on malformed protocol URLs (rust-lang/cargo#17548)
- fix(git)!: Default to net.git-fetch-with-cli if git is present (rust-lang/cargo#17329)
- Improved testsuite file permissions cleanup (rust-lang/cargo#17547)
- docs(guide): Give an example of checking for stale lockfile (rust-lang/cargo#17546)
- Add new peak memory table to cargo timings enabled via `-Zmem-stats` (rust-lang/cargo#17531)
- docs(changlog): Update 1.100.0 to reflect a beta backport (rust-lang/cargo#17542)
- feat(lint): Making the lint name a terminal hyperlink to docs (rust-lang/cargo#17538)
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors p=6
@bors cancel
Stuck

@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #163881.

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 7, 2026
Update cargo submodule

11 commits in f3865b2a4d1acc5276f6b3c67d0e057f4dab3928..45c3aacf0e8dabdcdb6b7b518db100061d6367a7
2026-09-29 19:58:08 +0000 to 2026-10-06 16:29:08 +0000
- feat(pkgid-spec): Builtin package spec parsing and formatting (rust-lang/cargo#17539)
- feat(hints): support minimum optimization levels (rust-lang/cargo#17368)
- Use trusted publishing for Cargo crates (rust-lang/cargo#17426)
- feat(trim-paths): stabilize `profile.trim-paths` (rust-lang/cargo#17488)
- fix(pkgid): avoid panic on malformed protocol URLs (rust-lang/cargo#17548)
- fix(git)!: Default to net.git-fetch-with-cli if git is present (rust-lang/cargo#17329)
- Improved testsuite file permissions cleanup (rust-lang/cargo#17547)
- docs(guide): Give an example of checking for stale lockfile (rust-lang/cargo#17546)
- Add new peak memory table to cargo timings enabled via `-Zmem-stats` (rust-lang/cargo#17531)
- docs(changlog): Update 1.100.0 to reflect a beta backport (rust-lang/cargo#17542)
- feat(lint): Making the lint name a terminal hyperlink to docs (rust-lang/cargo#17538)
@JonathanBrouwer

Copy link
Copy Markdown
Member

It got stuck on the same jobs twice in a row, which may indicate a problem with the PR
Logs show that test-x86_64-gnu-aux is in cargo's test suite and hasn't progressed in over 2 hours
https://triage.rust-lang.org/gha-logs/rust-lang/rust/112665634044
Can't find what it is stuck on tho

@bors r-
@bors p=1
@bors try jobs=test-aarch64-gnu,test-x86_64-gnu-aux

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 7, 2026
@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

View changes since this unapproval

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 7, 2026
Update cargo submodule


try-job: test-aarch64-gnu
try-job: test-x86_64-gnu-aux
@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

💔 Test for c91ed5a failed: CI

@weihanglo

Copy link
Copy Markdown
Member Author

Stuck again. Something bad in Cargo?

@JonathanBrouwer

Copy link
Copy Markdown
Member

Yeah I think is is somehow caused by the PR, but I can't even see which test is stuck, this is so confusing

@weihanglo

Copy link
Copy Markdown
Member Author

LLM helped find it. It was caused by ssh CLI hanging. I am preparing a Cargo PR. Thanks Jonathan!

@rustbot

This comment has been minimized.

@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors try jobs=test-aarch64-gnu,test-x86_64-gnu-aux

rust-bors Bot pushed a commit that referenced this pull request Oct 7, 2026
Update cargo submodule


try-job: test-aarch64-gnu
try-job: test-x86_64-gnu-aux
@rust-bors

This comment has been minimized.

@weihanglo

Copy link
Copy Markdown
Member Author

@bors try cancel

Ah, the fix commit hasn't yet included 😞

rust-lang/cargo#17563

I thought it were. Sorry.

@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Try build cancelled. Cancelled workflows:

Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run @bors try and bors will cancel the previous build automatically.

@rustbot

rustbot commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@weihanglo

Copy link
Copy Markdown
Member Author

Now it is really there

@bors try jobs=test-aarch64-gnu,test-x86_64-gnu-aux

rust-bors Bot pushed a commit that referenced this pull request Oct 7, 2026
Update cargo submodule


try-job: test-aarch64-gnu
try-job: test-x86_64-gnu-aux
@rust-bors

This comment has been minimized.

opensource-fork-sync Bot pushed a commit to cla7aye15I4nd/opensource-rust-lang__cargo that referenced this pull request Oct 8, 2026
### What does this PR try to resolve?

rust-lang/rust#163881 (comment)

Git CLI shelled out to ssh binary,
but in bootstrap dist's docker image there was no ssh client,
so it hung.

This PR fixes a variety of tests we overlooked when changing the
default.

### How to test and review this PR?

🤖 LLM disclosure: Bad tests were discovered by LLM, and changes were
made by hands.
@rust-bors

rust-bors Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 99b93c0 (99b93c0eff3a29be48690ddc4213dc9309b1a75b)
Base parent: 1d81eb4 (1d81eb4ad9cd207e3e638bd32b17ec4fce8412a6)

@weihanglo

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=1

@rust-bors

rust-bors Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 5e08891 has been approved by weihanglo

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 8, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 8, 2026
@rust-bors

rust-bors Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: weihanglo
Duration: 2h 51m 56s
Pushing 42cfc04 to main...

@rust-bors
rust-bors Bot merged commit 42cfc04 into rust-lang:main Oct 8, 2026
16 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 36aeef3 (parent) -> 42cfc04 (this PR)

Test differences

Show 23 test diffs

Stage 2

  • hints::min_opt_level_on_local_dependencies_without_feature_gate: [missing] -> pass (J0)
  • hints::min_opt_level_on_root_package: [missing] -> pass (J0)
  • hints::min_opt_level_registry_dependency_warnings_are_suppressed: [missing] -> pass (J0)
  • hints::min_opt_level_warning_is_emitted_once_per_package: [missing] -> pass (J0)
  • hints::min_opt_level_with_build_dependencies: [missing] -> pass (J0)
  • hints::min_opt_level_with_numeric_profiles: [missing] -> pass (J0)
  • hints::min_opt_level_with_out_of_range_values: [missing] -> pass (J0)
  • hints::min_opt_level_with_package_overrides: [missing] -> pass (J0)
  • hints::min_opt_level_with_size_profiles: [missing] -> pass (J0)
  • hints::min_opt_level_with_transitive_dependency: [missing] -> pass (J0)
  • hints::min_opt_level_with_wrong_type: [missing] -> pass (J0)
  • hints::min_opt_level_without_feature_gate: [missing] -> pass (J0)
  • profile_trim_paths::gated_config_toml: pass -> [missing] (J0)
  • profile_trim_paths::gated_manifest: pass -> [missing] (J0)
  • timings::peak_memory_not_reported_without_flag: [missing] -> pass (J0)
  • timings::peak_memory_reported: [missing] -> pass (J0)
  • timings::peak_memory_reported_on_failure: [missing] -> pass (J0)
  • git::dep_with_scp_like_submodule_url: pass -> ignore (CARGO_PUBLIC_NETWORK_TESTS must be set, ssh not installed) (J1)
  • git_auth::ssh_something_happens: pass -> ignore (ssh not installed) (J1)
  • git::dep_with_scp_like_submodule_url: pass -> ignore (CARGO_PUBLIC_NETWORK_TESTS must be set) (J2)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 42cfc04deaa723bc21611f3f9d7c8651be6300df --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-x86_64-gnu-distcheck: 1h 28m -> 2h 21m (+59.5%)
  2. dist-powerpc64le-linux-musl: 1h 6m -> 1h 41m (+54.0%)
  3. test-x86_64-gnu-stdlib-semver-check: 17m 9s -> 7m 58s (-53.5%)
  4. dist-ohos-armv7: 50m 52s -> 1h 17m (+52.5%)
  5. test-x86_64-gnu-llvm-22-1: 52m 7s -> 1h 16m (+45.9%)
  6. test-x86_64-rust-for-linux: 59m 4s -> 33m 25s (-43.4%)
  7. dist-ohos-x86_64: 57m 12s -> 1h 21m (+43.2%)
  8. test-x86_64-gnu-gcc: 53m 48s -> 1h 16m (+42.5%)
  9. dist-various-2: 36m 55s -> 52m 12s (+41.4%)
  10. test-x86_64-msvc-ext3: 1h 57m -> 1h 9m (-40.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (42cfc04): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.5%, secondary 1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.5% [0.5%, 0.5%] 1
Regressions ❌
(secondary)
1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.5% [0.5%, 0.5%] 1

Cycles

Results (primary -1.1%, secondary 5.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)
5.0% [4.2%, 5.8%] 2
Improvements ✅
(primary)
-2.2% [-2.2%, -2.1%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.1% [-2.2%, 1.2%] 3

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.639s -> 489.959s (-0.14%)
Artifact size: 408.64 MiB -> 408.60 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants