Skip to content

[PERF EXPERIMENT] Drop the previous-to-current dep-graph index mapping - #164130

Draft
xmakro wants to merge 2 commits into
rust-lang:mainfrom
xmakro:review/followup-on-pr1
Draft

xmakro wants to merge 2 commits into
rust-lang:mainfrom
xmakro:review/followup-on-pr1

Conversation

@xmakro

@xmakro xmakro commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Follow up of #164065.

Just testing perf for now. This PR has some cleanup because of the new invariant that prev_index == new_index in the depgraph which we want to introduce in #164065. This also allows us to stop collecting edges during the green marking walk, which should improve perf.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 11, 2026
@xmakro
xmakro force-pushed the review/followup-on-pr1 branch from c54ff2e to a923b6f Compare October 11, 2026 03:51
@panstromek

Copy link
Copy Markdown
Contributor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 11, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 11, 2026
[PERF EXPERIMENT] Drop the previous-to-current dep-graph index mapping
@rust-bors

rust-bors Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: b81e23e (b81e23e0985657f529ea25e039786448eaf4384d)
Base parent: 6f5da40 (6f5da406b56c2db6607202b63daee73aa8c61297)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (b81e23e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.2% [0.2%, 0.2%] 3
Regressions ❌
(secondary)
0.3% [0.2%, 0.4%] 9
Improvements ✅
(primary)
-2.8% [-8.3%, -0.1%] 136
Improvements ✅
(secondary)
-1.7% [-7.2%, -0.1%] 126
All ❌✅ (primary) -2.7% [-8.3%, 0.2%] 139

Max RSS (memory usage)

Results (primary -0.9%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.1% [2.8%, 3.5%] 3
Regressions ❌
(secondary)
5.5% [2.9%, 11.3%] 8
Improvements ✅
(primary)
-1.2% [-1.9%, -0.5%] 33
Improvements ✅
(secondary)
-2.3% [-3.7%, -0.6%] 12
All ❌✅ (primary) -0.9% [-1.9%, 3.5%] 36

Cycles

Results (primary -3.1%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.6% [2.6%, 8.7%] 2
Improvements ✅
(primary)
-3.1% [-5.5%, -1.8%] 38
Improvements ✅
(secondary)
-3.4% [-6.3%, -2.1%] 13
All ❌✅ (primary) -3.1% [-5.5%, -1.8%] 38

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 488.596s -> 489.56s (0.20%)
Artifact size: 407.26 MiB -> 406.67 MiB (-0.15%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 11, 2026
@rust-bors

rust-bors Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #165563) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants