Skip to content

[PAC] Allow mangled rust_eh_personality in pauth-attr-special-funcs test - #164436

Open
jchlanda wants to merge 1 commit into
rust-lang:mainfrom
jchlanda:jakub/pac_eh_personality_mangling
Open

[PAC] Allow mangled rust_eh_personality in pauth-attr-special-funcs test#164436
jchlanda wants to merge 1 commit into
rust-lang:mainfrom
jchlanda:jakub/pac_eh_personality_mangling

Conversation

@jchlanda

@jchlanda jchlanda commented Oct 16, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

The #148413 mangles the rust_eh_personality so the check has to be updated.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 16, 2026
@rustbot

rustbot commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 19 candidates

@rustbot

This comment has been minimized.

Sign in to view
@jchlanda
[PAC] Allow mangled rust_eh_personality in pauth-attr-special-funcs test
ceaf994 
Upstream started mangling the `rust_eh_personality` so the check has to be
updated.
@jchlanda
jchlanda force-pushed the jakub/pac_eh_personality_mangling branch from 6a2fac0 to ceaf994 Compare October 16, 2026 12:50
@oli-obk

oli-obk commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

what does PAC mean in this context 😅

@oli-obk

oli-obk commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

why do we need to change a test that isn't failing?

@oli-obk oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2026
@jchlanda

jchlanda commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

what does PAC mean in this context 😅

Apologies, should have been more verbose, it stands for pointer authentication.

why do we need to change a test that isn't failing?

The test taps into std::panic (and so is not a minicore). Because the CI does not build pauthtest's standard library the test is marked with //@ only-pauthtest. So it is skipped in the CI runs. But fails in the downstream testing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jchlanda @rustbot @oli-obk