Repository navigation
Stop mangling rust_eh_personality again for now - #164855
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @adwinwhite rustbot has assigned @adwinwhite. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
Some projects manually define rust_eh_personality as they use no_std on a target where libcore is compiled with panic=unwind and thus need rust_eh_personality to be present while it is only defined in libstd. These projects don't want to use unstable features and thus can't use a proper #[lang = "eh_personality"].
bjorn3
force-pushed
the
unmangle_personality
branch
from
October 24, 2026 14:07
cdef732 to
46bc916
Compare
Collaborator
|
Some changes occurred in tests/ui/sanitizer cc @rcvalle |
rustbot
added
A-run-make
Member
|
Is the assumption here that this is a "temporary" revert while we figure out a path for stable support for these projects? E.g., a stable attribute or perhaps It's unfortunate if mangling it ends up blocking on build-std or similar, IMO. |
Member
Author
|
Yeah, this would be temporary until a better solution is found. |
Member
|
In that case, @bors r+ r? me |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 24, 2026
…uwer Rollup of 7 pull requests Successful merges: - #163270 (Allow simd types in improper_ctypes lint) - #164855 (Stop mangling rust_eh_personality again for now) - #153679 (When multiple traits are applicable for method, do not specialize main message to the first one that applied) - #164248 (Retroactively add missing stabilized APIs to relnotes) - #164573 (Remove remaining mentions of `Unique`) - #164824 (PassWrapper: stop setting Options.ExceptionModel on LLVM 24) - #164844 (Add tracking issue for `#![feature(char_is_xid)]`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 24, 2026
Rollup merge of #164855 - bjorn3:unmangle_personality, r=Mark-Simulacrum Stop mangling rust_eh_personality again for now Some projects manually define rust_eh_personality as they use no_std on a target where libcore is compiled with panic=unwind and thus need rust_eh_personality to be present while it is only defined in libstd. These projects don't want to use unstable features and thus can't use a proper #[lang = "eh_personality"]. This reverts just the symbol mangling change of #148413. It preserves all the refactors to prevent codegen backends from hard coding the symbol name, so we can easily change it back to mangled in the future again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some projects manually define rust_eh_personality as they use no_std on a target where libcore is compiled with panic=unwind and thus need rust_eh_personality to be present while it is only defined in libstd. These projects don't want to use unstable features and thus can't use a proper #[lang = "eh_personality"].
This reverts just the symbol mangling change of #148413. It preserves all the refactors to prevent codegen backends from hard coding the symbol name, so we can easily change it back to mangled in the future again.