[cyrgani]

This PR does two things: first, a lot of outdated, confusing and unhelpful things are renamed. The last few commits then inline most of the larger functions in generic.rs into expand_ext, which allows the compiler to understand that several fields of TraitDef and MethodDef are only used once and don't need to be cloned, which gives some small perf gains.

Previous PR: #163485
r? @nnethercote

[panstromek]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: c82bfbd (c82bfbd448a8b52d3583642d7ad5398d34ffc48b)
Base parent: 92b5b8c (92b5b8c87c61b20adc9001b41baf587634a74734)

[rust-timer]

Finished benchmarking commit (c82bfbd): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=iffy rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.3%]	5
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	5
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.1%]	11
All ❌✅ (primary)	-0.2%	[-0.2%, -0.2%]	5

Max RSS (memory usage)

Results (secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	3
All ❌✅ (primary)	-	-	0

Bootstrap: 484.843s -> 484.517s (-0.07%)
Artifact size: 406.61 MiB -> 406.69 MiB (0.02%)