Repository navigation
make rlib object names deterministic - #165202
Open
paradoxicalguy wants to merge 1 commit into
Open
paradoxicalguy wants to merge 1 commit into
paradoxicalguy wants to merge 1 commit into
Conversation
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
paradoxicalguy
force-pushed
the
fix/deterministic-rlib-members
branch
from
October 30, 2026 19:13
153421a to
f2cf989
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
:/ okay |
paradoxicalguy
force-pushed
the
fix/deterministic-rlib-members
branch
from
October 30, 2026 21:39
f2cf989 to
a634851
Compare
Member
Author
|
updated the tests affected by the new deterministic object naming; adjusted the expected diagnostics in validated locally on with the full run-make, ui, incremental, llvm codegen, and codegen-units suites |
This comment has been minimized.
This comment has been minimized.
paradoxicalguy
force-pushed
the
fix/deterministic-rlib-members
branch
from
November 1, 2026 11:42
a634851 to
24b5f82
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, rustc's random temporary object filenames leaked into
.rlibarchive member names andlib.rmeta-link.with debuginfo enabled, absolute temporary paths also leaked into CodeView
S_OBJNAME, making builds non-reproducible.this change uses stable object names in archives, metadata, and CodeView while keeping temporary files unchanged.
result: byte-identical
.rlibs across different build directories, tested with 16 CGUs and-Cdebuginfo=2. added a regression test; normal linking and ThinLTO also pass.r? @bjorn3