Repository navigation
Conversation
Collaborator
|
r? @beetrees rustbot has assigned @beetrees. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
parser-where-clauses-fixes
branch
4 times, most recently
from
October 31, 2026 22:05
8425e6b to
db5181f
Compare
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
parser-where-clauses-fixes
branch
2 times, most recently
from
October 31, 2026 22:58
ff47213 to
668b5c9
Compare
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
parser-where-clauses-fixes
branch
from
November 2, 2026 23:16
668b5c9 to
3dbebfe
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
parser-where-clauses-fixes
branch
2 times, most recently
from
November 6, 2026 09:45
ceccfbd to
724c67c
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
fmease
force-pushed
the
parser-where-clauses-fixes
branch
2 times, most recently
from
November 6, 2026 09:47
588a7d9 to
082df29
Compare
Previously they were separate because they each contained a fatal parse error. However, by introducing "barrier functions" we give the parser synchronization points to successfully recover from these syntax errors allowing us to put both test cases into the same file. We call the combined file `where-clause-predicates.rs` because it took me a while to realize that this test mainly means to test where clause predicates themselves and not *type aliases with where clauses*. See also PR RUST-39158 which introduced these files and which is about "bound parsing" in general. This makes it alot clearer which UI tests actually concern where clauses on type aliases *specifically* allowing me to more easily find an existing test file I can extend with test cases covering "double where clauses", namely `tests/ui/where-clauses/where-clause-placement-type-alias.rs`.
There's no reason to return a large tuple that the caller then has to convert into an `ItemKind`. None of the callers care about the concrete fields. In the case of `parse_const_item` it's likely a remnant of the time when it was used to parse (or rather finish parsing) const (`ItemKind::Const`) *and* static items (`ItemKind::Static`).
…less type aliases / associated types.
…uses on bodiless associated types
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whereclause #93571 (submitted & merged: Feb 2022) at basically the same time as trailing where clauses for type aliases were introduced in PR Change location of where clause on GATs #90076 (submitted: Oct 2021, merged: Mar 2022)where where(i.e., duplicate empty where clauses) on const items (unstable featuregeneric_const_items). See commit for details.Best reviewed commit by commit.
(No LLM was or will be used by me during the entire creation process of this PR)