Skip to content

LLVMRustWriteOutputFile: Check the result of runCodeGenPipeline - #165408

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
zmodem:check_error
Nov 3, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
zmodem:check_error

Conversation

@zmodem

@zmodem zmodem commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Otherwise the llvm::Error object's destructor asserts.

This is a follow-up to #163672

Otherwise the llvm::Error object's destrcutor asserts.
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 3, 2026
@rustbot

rustbot commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @cuviper

@zmodem

zmodem commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot label llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Nov 3, 2026
@zmodem

zmodem commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

r? @nikic

Also cc @boomanaiden154

@rustbot rustbot assigned nikic and unassigned cuviper Nov 3, 2026

@boomanaiden154 boomanaiden154 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikic

nikic commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 855689d has been tentatively approved by nikic

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 3, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #165416 (fix unsoundness when compiling `[diverging_const; 0]`)
 - #163217 ([perf] rustdoc: Avoid re-HIR-ty-lowering tys & const args where possible)
 - #165371 (Don't use `llvm_type` as the type of `static`s.)
 - #165354 (Remove `AbiAlign`)
 - #165357 (rustdoc: Fix invalid clean of paths when they end with `self`)
 - #165401 (Add codegen test for step_by(1) loop vectorization)
 - #165408 (LLVMRustWriteOutputFile: Check the result of runCodeGenPipeline)
@rust-bors
rust-bors Bot merged commit 4a7ed2a into rust-lang:main Nov 3, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Nov 3, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 3, 2026
Rollup merge of #165408 - zmodem:check_error, r=nikic

LLVMRustWriteOutputFile: Check the result of runCodeGenPipeline

Otherwise the llvm::Error object's destructor asserts.

This is a follow-up to #163672
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Nov 4, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#165416 (fix unsoundness when compiling `[diverging_const; 0]`)
 - rust-lang/rust#163217 ([perf] rustdoc: Avoid re-HIR-ty-lowering tys & const args where possible)
 - rust-lang/rust#165371 (Don't use `llvm_type` as the type of `static`s.)
 - rust-lang/rust#165354 (Remove `AbiAlign`)
 - rust-lang/rust#165357 (rustdoc: Fix invalid clean of paths when they end with `self`)
 - rust-lang/rust#165401 (Add codegen test for step_by(1) loop vectorization)
 - rust-lang/rust#165408 (LLVMRustWriteOutputFile: Check the result of runCodeGenPipeline)
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Nov 5, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#165416 (fix unsoundness when compiling `[diverging_const; 0]`)
 - rust-lang/rust#163217 ([perf] rustdoc: Avoid re-HIR-ty-lowering tys & const args where possible)
 - rust-lang/rust#165371 (Don't use `llvm_type` as the type of `static`s.)
 - rust-lang/rust#165354 (Remove `AbiAlign`)
 - rust-lang/rust#165357 (rustdoc: Fix invalid clean of paths when they end with `self`)
 - rust-lang/rust#165401 (Add codegen test for step_by(1) loop vectorization)
 - rust-lang/rust#165408 (LLVMRustWriteOutputFile: Check the result of runCodeGenPipeline)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants